Skip to content

Commit 53e62af

Browse files
jaimecbernardoCommit Bot
authored andcommitted
[build] Include string in v8.h
Explicitly #include<string> in v8.h, since std::string is referenced in it. In the C++ STL shipped with Visual Studio 2019, none of the headers included in v8.h ends up including the C++ string header, which caused a compile error. Bug: v8:9793 Change-Id: I84a133dd10dd6dcc7b70287af393e82cf0dc97df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834321 Reviewed-by: Adam Klein <[email protected]> Commit-Queue: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/master@{#64074}
1 parent 472aff9 commit 53e62af

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

include/v8.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#include <stdint.h>
2020
#include <stdio.h>
2121
#include <memory>
22+
#include <string>
2223
#include <type_traits>
2324
#include <utility>
2425
#include <vector>

0 commit comments

Comments
 (0)