[gcc] Fix gcc / bazel build

LeszekSwirski · V8 LUCI CQ · commit 500de8bd371b · 2024-03-22T17:43:49.000Z
Add <iomanip> includes to fix gcc/blaze builds. Also ignore a dangling pointer warning introduced in newer gcc, since it has false positives on some uses of scope classes. Change-Id: Ib86a2437ffc34b5497a5b8619013d6d5b4ea30fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5380192 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#92977}
diff --git a/BUILD.gn b/BUILD.gn
@@ -1714,6 +1714,10 @@ config("toolchain") {
 
       # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108517
       "-Wno-nonnull",
+
+      # Disable dangling pointer warnings, which are often false positives when
+      # using scopes.
+      "-Wno-dangling-pointer",
     ]
   }
 
diff --git a/src/compiler/turboshaft/assembler.h b/src/compiler/turboshaft/assembler.h
@@ -6,6 +6,7 @@
 #define V8_COMPILER_TURBOSHAFT_ASSEMBLER_H_
 
 #include <cstring>
+#include <iomanip>
 #include <iterator>
 #include <limits>
 #include <memory>
diff --git a/src/wasm/wasm-disassembler.cc b/src/wasm/wasm-disassembler.cc
@@ -4,6 +4,8 @@
 
 #include "src/wasm/wasm-disassembler.h"
 
+#include <iomanip>
+
 #include "src/debug/debug-interface.h"
 #include "src/numbers/conversions.h"
 #include "src/wasm/module-decoder-impl.h"

Original file line number	Diff line number	Diff line change
`@@ -1714,6 +1714,10 @@ config("toolchain") {`
`1714`	`1714`
`1715`	`1715`	`# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108517`
`1716`	`1716`	`"-Wno-nonnull",`
	`1717`	`+`
	`1718`	`+ # Disable dangling pointer warnings, which are often false positives when`
	`1719`	`+ # using scopes.`
	`1720`	`+ "-Wno-dangling-pointer",`
`1717`	`1721`	`]`
`1718`	`1722`	`}`
`1719`	`1723`