[compiler] Don't elide ChangeTaggedToInt32->ChangeInt31ToTaggedSigned

LeszekSwirski · V8 LUCI CQ · commit 4fae8b16802a · 2021-12-10T15:36:42.000Z
Bug: chromium:1278387 Change-Id: If834ee2f9ba3663822a8066fbd1ece49c24023da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3329790 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#78337}
diff --git a/src/compiler/simplified-operator-reducer.cc b/src/compiler/simplified-operator-reducer.cc
@@ -77,7 +77,7 @@ Reduction SimplifiedOperatorReducer::Reduce(Node* node) {
     case IrOpcode::kChangeInt32ToTagged: {
       Int32Matcher m(node->InputAt(0));
       if (m.HasResolvedValue()) return ReplaceNumber(m.ResolvedValue());
-      if (m.IsChangeTaggedToInt32() || m.IsChangeTaggedSignedToInt32()) {
+      if (m.IsChangeTaggedSignedToInt32()) {
         return Replace(m.InputAt(0));
       }
       break;

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ Reduction SimplifiedOperatorReducer::Reduce(Node* node) {`
`77`	`77`	`case IrOpcode::kChangeInt32ToTagged: {`
`78`	`78`	`Int32Matcher m(node->InputAt(0));`
`79`	`79`	`if (m.HasResolvedValue()) return ReplaceNumber(m.ResolvedValue());`
`80`		`- if (m.IsChangeTaggedToInt32() \|\| m.IsChangeTaggedSignedToInt32()) {`
	`80`	`+ if (m.IsChangeTaggedSignedToInt32()) {`
`81`	`81`	`return Replace(m.InputAt(0));`
`82`	`82`	`}`
`83`	`83`	`break;`