Skip to content

Commit 43791ce

Browse files
alexkozyCommit bot
authored andcommitted
[inspector] finally removed *ExecuteScript from inspector
We don't need hints from embedder any more. BUG=none [email protected] Review-Url: https://codereview.chromium.org/2773143002 Cr-Commit-Position: refs/heads/master@{#44158}
1 parent 6235899 commit 43791ce

File tree

3 files changed

+0
-11
lines changed

3 files changed

+0
-11
lines changed

include/v8-inspector.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,6 @@ class V8_EXPORT V8Inspector {
224224
virtual void resetContextGroup(int contextGroupId) = 0;
225225

226226
// Various instrumentation.
227-
virtual void willExecuteScript(v8::Local<v8::Context>, int scriptId) = 0;
228-
virtual void didExecuteScript(v8::Local<v8::Context>) = 0;
229227
virtual void idleStarted() = 0;
230228
virtual void idleFinished() = 0;
231229

src/inspector/v8-inspector-impl.cc

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -239,13 +239,6 @@ void V8InspectorImpl::resetContextGroup(int contextGroupId) {
239239
m_debugger->wasmTranslation()->Clear();
240240
}
241241

242-
void V8InspectorImpl::willExecuteScript(v8::Local<v8::Context> context,
243-
int scriptId) {
244-
}
245-
246-
void V8InspectorImpl::didExecuteScript(v8::Local<v8::Context> context) {
247-
}
248-
249242
void V8InspectorImpl::idleStarted() {
250243
for (auto it = m_sessions.begin(); it != m_sessions.end(); ++it) {
251244
if (it->second->profilerAgent()->idleStarted()) return;

src/inspector/v8-inspector-impl.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,6 @@ class V8InspectorImpl : public V8Inspector {
7474
void contextCreated(const V8ContextInfo&) override;
7575
void contextDestroyed(v8::Local<v8::Context>) override;
7676
void resetContextGroup(int contextGroupId) override;
77-
void willExecuteScript(v8::Local<v8::Context>, int scriptId) override;
78-
void didExecuteScript(v8::Local<v8::Context>) override;
7977
void idleStarted() override;
8078
void idleFinished() override;
8179
unsigned exceptionThrown(v8::Local<v8::Context>, const StringView& message,

0 commit comments

Comments
 (0)