[bigint] Fix possibly-uninitialized leading digit on right shift

jakobkummerow · Commit Bot · commit 412ac52d8246 · 2021-01-19T17:59:52.000Z
(cherry picked from commit e82a3b4) (cherry picked from commit 1162c46) No-Try: true No-Presubmit: true No-Tree-Checks: true Fixed: chromium:1151890 Change-Id: I26f5c76494a9ff3f5a141f381e1c9a543e368571 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2561618 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#71422} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565245 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/8.7@{#57} Cr-Original-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Original-Branched-From: 942c2ef-refs/heads/master@{#70196} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2624611 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/branch-heads/8.6@{#54} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
diff --git a/src/objects/bigint.cc b/src/objects/bigint.cc
@@ -1861,6 +1861,8 @@ Handle<BigInt> MutableBigInt::RightShiftByAbsolute(Isolate* isolate,
   DCHECK_LE(result_length, length);
   Handle<MutableBigInt> result = New(isolate, result_length).ToHandleChecked();
   if (bits_shift == 0) {
+    // Zero out any overflow digit (see "rounding_can_overflow" above).
+    result->set_digit(result_length - 1, 0);
     for (int i = digit_shift; i < length; i++) {
       result->set_digit(i - digit_shift, x->digit(i));
     }
diff --git a/test/mjsunit/regress/regress-crbug-1151890.js b/test/mjsunit/regress/regress-crbug-1151890.js
@@ -0,0 +1,11 @@
+// Copyright 2020 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+for (let i = 0, j = 0; i < 10; ++i) {
+  let x = (-0xffffffffffffffff_ffffffffffffffffn >> 0x40n);
+  assertEquals(-0x10000000000000000n, x);
+  %SimulateNewspaceFull();
+}

Original file line number	Diff line number	Diff line change
`@@ -1861,6 +1861,8 @@ Handle<BigInt> MutableBigInt::RightShiftByAbsolute(Isolate* isolate,`
`1861`	`1861`	`DCHECK_LE(result_length, length);`
`1862`	`1862`	`Handle<MutableBigInt> result = New(isolate, result_length).ToHandleChecked();`
`1863`	`1863`	`if (bits_shift == 0) {`
	`1864`	`+ // Zero out any overflow digit (see "rounding_can_overflow" above).`
	`1865`	`+ result->set_digit(result_length - 1, 0);`
`1864`	`1866`	`for (int i = digit_shift; i < length; i++) {`
`1865`	`1867`	`result->set_digit(i - digit_shift, x->digit(i));`
`1866`	`1868`	`}`