GCC: explicitely instantiate JSObject::ApplyAttributesToDictionary for NumberDictionary

Jose Dapena Paz · Commit Bot · commit 3b8c624bda58 · 2019-06-11T14:36:05.000Z
elements.cc invokes ApplyAttributesToDictionary using NumberDictionary as its template parameter. But the declaration of the template method is in js-object.cc, so nobody can actually compile the version for number dictionary. This is fixed requesting explicit instantiation for NumberDictionary. This was breaking GCC build. Bug: chromium:819294 Change-Id: I685ddc5b97e129d1a534dbdb04025c0932bc5ecd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649565 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#62097}
diff --git a/AUTHORS b/AUTHORS
@@ -15,6 +15,7 @@ NVIDIA Corporation <*@nvidia.com>
 BlackBerry Limited <*@blackberry.com>
 Opera Software ASA <*@opera.com>
 Intel Corporation <*@intel.com>
+LG Electronics, Inc. <*@lge.com>
 Microsoft <*@microsoft.com>
 MIPS Technologies, Inc. <*@mips.com>
 Imagination Technologies, LLC <*@imgtec.com>
diff --git a/src/objects/js-objects.cc b/src/objects/js-objects.cc
@@ -3753,6 +3753,10 @@ void JSObject::ApplyAttributesToDictionary(
   }
 }
 
+template void JSObject::ApplyAttributesToDictionary(
+    Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
+    const PropertyAttributes attributes);
+
 template <PropertyAttributes attrs>
 Maybe<bool> JSObject::PreventExtensionsWithTransition(
     Handle<JSObject> object, ShouldThrow should_throw) {

Original file line number	Diff line number	Diff line change
`@@ -3753,6 +3753,10 @@ void JSObject::ApplyAttributesToDictionary(`
`3753`	`3753`	`}`
`3754`	`3754`	`}`
`3755`	`3755`
	`3756`	`+template void JSObject::ApplyAttributesToDictionary(`
	`3757`	`+ Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,`
	`3758`	`+ const PropertyAttributes attributes);`
	`3759`	`+`
`3756`	`3760`	`template <PropertyAttributes attrs>`
`3757`	`3761`	`Maybe<bool> JSObject::PreventExtensionsWithTransition(`
`3758`	`3762`	`Handle<JSObject> object, ShouldThrow should_throw) {`