Commit 3b1cfa3
Revert "Merged: Revert "Enable icu-timezone-data by default""
This reverts commit d734370.
Reason for revert: broke some branch builders like https://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20beta%20branch%20-%20debug
Original change's description:
> Merged: Revert "Enable icu-timezone-data by default"
>
> This reverts commit d9a2584.
> This is for 6.3 branch (to go with Chromium 63 branch).
>
> Reason for revert:
>
> I'm reverting this CL for a few reasons. #2 is the most significant and
> I should have thought of that before making a switch. Sorry for that.
>
> 1) perf-regression: http://crbug.com/769706
> 2) http://crbug.com/612010 : ICU timezone update is not propagated to
> zygote process so that new tabs will hold on to an old timezone even
> after a timezone change on Linux and Chrome OS.
>
> 3) http://crbug.com/754053 : OS timezone detection issues on macOS
> 10.13, Ubutu 16, RHEL 7, SuSe Linux 12 or newer. ; it's being fixed. So,
> it actually ok.
>
> 4) http://crbug.com/771868 : timezone wrong in gmail: If it's due to
>
> Revision: 28ef8dc
>
> BUG=chromium:612010,chromium:769706,chromium:771868,v8:2137,v8:6031,v8:6076
> LOG=N
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
> R=[email protected], [email protected]
>
> Change-Id: Id0093c2bc69e5bc1d3b7147b7bbcc633ed625a45
> Reviewed-on: https://chromium-review.googlesource.com/721919
> Reviewed-by: Adam Klein <[email protected]>
> Commit-Queue: Jungshik Shin <[email protected]>
> Cr-Commit-Position: refs/branch-heads/6.3@{#7}
> Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
> Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
[email protected],[email protected],[email protected]
Change-Id: I8b30f8f9c63b93cb000facbf910ed111ca3f9ab2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:612010, chromium:769706, chromium:771868, v8:2137, v8:6031, v8:6076
Reviewed-on: https://chromium-review.googlesource.com/723324
Reviewed-by: Michael Hablich <[email protected]>
Commit-Queue: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#18}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}1 parent 9a132a9 commit 3b1cfa3
1 file changed
+1
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
269 | | - | |
270 | | - | |
| 269 | + | |
271 | 270 | | |
272 | 271 | | |
273 | 272 | | |
| |||
0 commit comments