Skip to content

Commit 394a805

Browse files
luyahanV8 LUCI CQ
authored andcommitted
[riscv] Check trampoline before Constant pool in Release mode
Change-Id: I9645cded9328dabb2c11c7859b998c838b95f97b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6653368 Commit-Queue: Ji Qiu <[email protected]> Reviewed-by: Ji Qiu <[email protected]> Cr-Commit-Position: refs/heads/main@{#100935}
1 parent e62f625 commit 394a805

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

src/codegen/riscv/macro-assembler-riscv.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4978,10 +4978,9 @@ void MacroAssembler::Jump(Register target, Condition cond, Register rs,
49784978
jr(target);
49794979
DEBUG_PRINTF("\tCheckTrampolinePool pc_offset:%d %d\n", pc_offset(),
49804980
next_buffer_check() - ConstpoolComputesize());
4981-
if (!is_trampoline_emitted() && v8_flags.debug_code &&
4981+
if (!is_trampoline_emitted() &&
49824982
pc_offset() >= (next_buffer_check() - ConstpoolComputesize())) {
4983-
// Debug mode will emit more instrs than Release mode.
4984-
// so we need to check trampoline pool before Constant pool.
4983+
// We need to check trampoline pool before Constant pool.
49854984
// Here need to emit trampoline first.
49864985
// Jump(ra, al) will block trampoline pool for 1 instr.
49874986
nop();

0 commit comments

Comments
 (0)