Make v8::Eternal::Get and IsEmpty const.

jeremyroman · Commit bot · commit 3700a01c8243 · 2017-03-17T14:48:20.000Z
They do not modify the state of the handle. Review-Url: https://codereview.chromium.org/2753973002 Cr-Commit-Position: refs/heads/master@{#43907}
diff --git a/include/v8.h b/include/v8.h
@@ -366,8 +366,8 @@ template <class T> class Eternal {
     Set(isolate, handle);
   }
   // Can only be safely called if already set.
-  V8_INLINE Local<T> Get(Isolate* isolate);
-  V8_INLINE bool IsEmpty() { return index_ == kInitialValue; }
+  V8_INLINE Local<T> Get(Isolate* isolate) const;
+  V8_INLINE bool IsEmpty() const { return index_ == kInitialValue; }
   template<class S> V8_INLINE void Set(Isolate* isolate, Local<S> handle);
 
  private:
@@ -8644,9 +8644,8 @@ void Eternal<T>::Set(Isolate* isolate, Local<S> handle) {
   V8::Eternalize(isolate, reinterpret_cast<Value*>(*handle), &this->index_);
 }
 
-
-template<class T>
-Local<T> Eternal<T>::Get(Isolate* isolate) {
+template <class T>
+Local<T> Eternal<T>::Get(Isolate* isolate) const {
   return Local<T>(reinterpret_cast<T*>(*V8::GetEternal(isolate, index_)));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -366,8 +366,8 @@ template <class T> class Eternal {`
`366`	`366`	`Set(isolate, handle);`
`367`	`367`	`}`
`368`	`368`	`// Can only be safely called if already set.`
`369`		`- V8_INLINE Local<T> Get(Isolate* isolate);`
`370`		`- V8_INLINE bool IsEmpty() { return index_ == kInitialValue; }`
	`369`	`+ V8_INLINE Local<T> Get(Isolate* isolate) const;`
	`370`	`+ V8_INLINE bool IsEmpty() const { return index_ == kInitialValue; }`
`371`	`371`	`template<class S> V8_INLINE void Set(Isolate* isolate, Local<S> handle);`
`372`	`372`
`373`	`373`	`private:`
`@@ -8644,9 +8644,8 @@ void Eternal<T>::Set(Isolate* isolate, Local<S> handle) {`
`8644`	`8644`	`V8::Eternalize(isolate, reinterpret_cast<Value>(handle), &this->index_);`
`8645`	`8645`	`}`
`8646`	`8646`
`8647`		`-`
`8648`		`-template<class T>`
`8649`		`-Local<T> Eternal<T>::Get(Isolate* isolate) {`
	`8647`	`+template <class T>`
	`8648`	`+Local<T> Eternal<T>::Get(Isolate* isolate) const {`
`8650`	`8649`	`return Local<T>(reinterpret_cast<T>(V8::GetEternal(isolate, index_)));`
`8651`	`8650`	`}`
`8652`	`8651`