Skip to content

Commit 313bc6d

Browse files
domfarolinoCommit Bot
domfarolino
authored and
Commit Bot
committed
[inspector] remove deprecated console methods
As per whatwg/console#27 (comment) and https://bugs.chromium.org/p/chromium/issues/detail?id=706804 we're leaving the console timeline/timelineEnd methods out of the specification and testing that implementations do not expose them (relevant WPTs at https://github.com/web-platform-tests/wpt/blob/master/console/console-tests-historical.any.js). Their implementations should be removed from Chrome, one of the last implementers of these legacy methods. The same goes for markTimeline, as it is deprecated in Chrome and not being included in the spec. [email protected], [email protected] Bug: chromium:706804 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibe05848fb664d26d16eeb5bdf6f519c1eeb4b2df Reviewed-on: https://chromium-review.googlesource.com/1082112 Reviewed-by: Yang Guo <[email protected]> Reviewed-by: Aleksey Kozyatinskiy <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/master@{#53973}
1 parent f2b90bd commit 313bc6d

9 files changed

Lines changed: 6 additions & 94 deletions

‎src/bootstrapper.cc‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2837,16 +2837,10 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
28372837
Builtins::kConsoleCountReset, 1, false, NONE);
28382838
SimpleInstallFunction(isolate_, console, "assert",
28392839
Builtins::kFastConsoleAssert, 1, false, NONE);
2840-
SimpleInstallFunction(isolate_, console, "markTimeline",
2841-
Builtins::kConsoleMarkTimeline, 1, false, NONE);
28422840
SimpleInstallFunction(isolate_, console, "profile",
28432841
Builtins::kConsoleProfile, 1, false, NONE);
28442842
SimpleInstallFunction(isolate_, console, "profileEnd",
28452843
Builtins::kConsoleProfileEnd, 1, false, NONE);
2846-
SimpleInstallFunction(isolate_, console, "timeline",
2847-
Builtins::kConsoleTimeline, 1, false, NONE);
2848-
SimpleInstallFunction(isolate_, console, "timelineEnd",
2849-
Builtins::kConsoleTimelineEnd, 1, false, NONE);
28502844
SimpleInstallFunction(isolate_, console, "time", Builtins::kConsoleTime, 1,
28512845
false, NONE);
28522846
SimpleInstallFunction(isolate_, console, "timeEnd",

‎src/builtins/builtins-console.cc‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,8 @@ namespace internal {
3232
V(Count, count) \
3333
V(CountReset, countReset) \
3434
V(Assert, assert) \
35-
V(MarkTimeline, markTimeline) \
3635
V(Profile, profile) \
37-
V(ProfileEnd, profileEnd) \
38-
V(Timeline, timeline) \
39-
V(TimelineEnd, timelineEnd)
36+
V(ProfileEnd, profileEnd)
4037

4138
namespace {
4239
void ConsoleCall(

‎src/builtins/builtins-definitions.h‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -483,11 +483,8 @@ namespace internal {
483483
CPP(ConsoleCountReset) \
484484
CPP(ConsoleAssert) \
485485
TFJ(FastConsoleAssert, SharedFunctionInfo::kDontAdaptArgumentsSentinel) \
486-
CPP(ConsoleMarkTimeline) \
487486
CPP(ConsoleProfile) \
488487
CPP(ConsoleProfileEnd) \
489-
CPP(ConsoleTimeline) \
490-
CPP(ConsoleTimelineEnd) \
491488
CPP(ConsoleTime) \
492489
CPP(ConsoleTimeEnd) \
493490
CPP(ConsoleTimeStamp) \

‎src/debug/interface-types.h‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -155,16 +155,10 @@ class ConsoleDelegate {
155155
const ConsoleContext& context) {}
156156
virtual void Assert(const ConsoleCallArguments& args,
157157
const ConsoleContext& context) {}
158-
virtual void MarkTimeline(const ConsoleCallArguments& args,
159-
const ConsoleContext& context) {}
160158
virtual void Profile(const ConsoleCallArguments& args,
161159
const ConsoleContext& context) {}
162160
virtual void ProfileEnd(const ConsoleCallArguments& args,
163161
const ConsoleContext& context) {}
164-
virtual void Timeline(const ConsoleCallArguments& args,
165-
const ConsoleContext& context) {}
166-
virtual void TimelineEnd(const ConsoleCallArguments& args,
167-
const ConsoleContext& context) {}
168162
virtual void Time(const ConsoleCallArguments& args,
169163
const ConsoleContext& context) {}
170164
virtual void TimeEnd(const ConsoleCallArguments& args,

‎src/inspector/v8-console.cc‎

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -345,16 +345,6 @@ void V8Console::Assert(const v8::debug::ConsoleCallArguments& info,
345345
m_inspector->debugger()->breakProgramOnAssert(helper.groupId());
346346
}
347347

348-
void V8Console::MarkTimeline(const v8::debug::ConsoleCallArguments& info,
349-
const v8::debug::ConsoleContext& consoleContext) {
350-
ConsoleHelper(info, consoleContext, m_inspector)
351-
.reportDeprecatedCall("V8Console#markTimelineDeprecated",
352-
"'console.markTimeline' is "
353-
"deprecated. Please use "
354-
"'console.timeStamp' instead.");
355-
TimeStamp(info, consoleContext);
356-
}
357-
358348
void V8Console::Profile(const v8::debug::ConsoleCallArguments& info,
359349
const v8::debug::ConsoleContext& consoleContext) {
360350
ConsoleHelper helper(info, consoleContext, m_inspector);
@@ -414,25 +404,6 @@ static void timeEndFunction(const v8::debug::ConsoleCallArguments& info,
414404
helper.reportCallWithArgument(ConsoleAPIType::kTimeEnd, message);
415405
}
416406

417-
void V8Console::Timeline(const v8::debug::ConsoleCallArguments& info,
418-
const v8::debug::ConsoleContext& consoleContext) {
419-
ConsoleHelper(info, consoleContext, m_inspector)
420-
.reportDeprecatedCall("V8Console#timeline",
421-
"'console.timeline' is deprecated. Please use "
422-
"'console.time' instead.");
423-
timeFunction(info, consoleContext, true, m_inspector);
424-
}
425-
426-
void V8Console::TimelineEnd(const v8::debug::ConsoleCallArguments& info,
427-
const v8::debug::ConsoleContext& consoleContext) {
428-
ConsoleHelper(info, consoleContext, m_inspector)
429-
.reportDeprecatedCall("V8Console#timelineEnd",
430-
"'console.timelineEnd' is "
431-
"deprecated. Please use "
432-
"'console.timeEnd' instead.");
433-
timeEndFunction(info, consoleContext, true, m_inspector);
434-
}
435-
436407
void V8Console::Time(const v8::debug::ConsoleCallArguments& info,
437408
const v8::debug::ConsoleContext& consoleContext) {
438409
timeFunction(info, consoleContext, false, m_inspector);

‎src/inspector/v8-console.h‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,16 +82,10 @@ class V8Console : public v8::debug::ConsoleDelegate {
8282
const v8::debug::ConsoleContext& consoleContext) override;
8383
void Assert(const v8::debug::ConsoleCallArguments&,
8484
const v8::debug::ConsoleContext& consoleContext) override;
85-
void MarkTimeline(const v8::debug::ConsoleCallArguments&,
86-
const v8::debug::ConsoleContext& consoleContext) override;
8785
void Profile(const v8::debug::ConsoleCallArguments&,
8886
const v8::debug::ConsoleContext& consoleContext) override;
8987
void ProfileEnd(const v8::debug::ConsoleCallArguments&,
9088
const v8::debug::ConsoleContext& consoleContext) override;
91-
void Timeline(const v8::debug::ConsoleCallArguments&,
92-
const v8::debug::ConsoleContext& consoleContext) override;
93-
void TimelineEnd(const v8::debug::ConsoleCallArguments&,
94-
const v8::debug::ConsoleContext& consoleContext) override;
9589
void Time(const v8::debug::ConsoleCallArguments&,
9690
const v8::debug::ConsoleContext& consoleContext) override;
9791
void TimeEnd(const v8::debug::ConsoleCallArguments&,

‎test/inspector/runtime/console-context-expected.txt‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,11 @@ console.context() methods:
2626
[13] : count
2727
[14] : countReset
2828
[15] : assert
29-
[16] : markTimeline
30-
[17] : profile
31-
[18] : profileEnd
32-
[19] : timeline
33-
[20] : timelineEnd
34-
[21] : time
35-
[22] : timeEnd
36-
[23] : timeStamp
29+
[16] : profile
30+
[17] : profileEnd
31+
[18] : time
32+
[19] : timeEnd
33+
[20] : timeStamp
3734
]
3835

3936
Running test: testDefaultConsoleContext

‎test/inspector/runtime/console-deprecated-methods-expected.txt‎

Lines changed: 0 additions & 4 deletions
This file was deleted.

‎test/inspector/runtime/console-deprecated-methods.js‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)