Skip to content

Commit 2947a4e

Browse files
sygV8 LUCI CQ
syg
authored and
V8 LUCI CQ
committed
Revert "[intl] Fix {minute: '2-digit'}"
This reverts commit b615443. Reason for revert: Possibly web incompatible; see issue 358045506 Original change's description: > [intl] Fix {minute: '2-digit'} > > Set the correct ICU option flag to respect all field length for pattern > matching. > > Fixed: 40855035 > Change-Id: I4b89301e4ad98e3db97708a309d11823da8c026f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5646178 > Reviewed-by: Shu-yu Guo <[email protected]> > Commit-Queue: Frank Tang <[email protected]> > Cr-Commit-Position: refs/heads/main@{#94613} Bug: 358045506 Change-Id: I97924a25e3b278844e31cdf15a1ca232b5249256 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5785865 Commit-Queue: Shu-yu Guo <[email protected]> Reviewed-by: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/main@{#95616}
1 parent bda827a commit 2947a4e

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

‎src/objects/js-date-time-format.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1844,7 +1844,7 @@ std::unique_ptr<icu::SimpleDateFormat> CreateICUDateFormat(
18441844
// has to be discussed. Revisit once the spec is clarified/revised.
18451845
icu::UnicodeString pattern;
18461846
UErrorCode status = U_ZERO_ERROR;
1847-
pattern = generator->getBestPattern(skeleton, UDATPG_MATCH_ALL_FIELDS_LENGTH,
1847+
pattern = generator->getBestPattern(skeleton, UDATPG_MATCH_HOUR_FIELD_LENGTH,
18481848
status);
18491849
pattern = ReplaceHourCycleInPattern(pattern, hc);
18501850
DCHECK(U_SUCCESS(status));

‎test/intl/regress-40855035.js‎

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)