Skip to content

Commit 28f07b1

Browse files
mtbrandyCommit bot
authored andcommitted
[turbofan] Fix unified stack slots for embedded constant pools.
Account for the constant pool pointer slot during register allocation data initialization. [email protected], [email protected], [email protected], [email protected], TEST=cctest/test-run-machops/RunSpillConstantsAndParameters BUG= Review URL: https://codereview.chromium.org/1317123003 Cr-Commit-Position: refs/heads/master@{#30430}
1 parent ad3a8f0 commit 28f07b1

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/compiler/pipeline.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,8 @@ class PipelineData {
266266
int fixed_frame_size = 0;
267267
if (descriptor != nullptr) {
268268
fixed_frame_size = (descriptor->kind() == CallDescriptor::kCallAddress)
269-
? StandardFrameConstants::kFixedSlotCountAboveFp
269+
? StandardFrameConstants::kFixedSlotCountAboveFp +
270+
StandardFrameConstants::kCPSlotCount
270271
: StandardFrameConstants::kFixedSlotCount;
271272
}
272273
frame_ = new (instruction_zone()) Frame(fixed_frame_size);

src/frames.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ class StandardFrameConstants : public AllStatic {
126126
static const int kFixedSlotCountAboveFp =
127127
kFixedFrameSizeAboveFp / kPointerSize;
128128
static const int kFixedSlotCount = kFixedFrameSize / kPointerSize;
129+
static const int kCPSlotCount = kCPSlotSize / kPointerSize;
129130
static const int kExpressionsOffset = -3 * kPointerSize - kCPSlotSize;
130131
static const int kMarkerOffset = -2 * kPointerSize - kCPSlotSize;
131132
static const int kContextOffset = -1 * kPointerSize - kCPSlotSize;

0 commit comments

Comments
 (0)