[import-attributes] Deprecate 'assert' for dynamic import as well

syg · V8 LUCI CQ · commit 26fd1dfa9cd6 · 2024-01-31T16:55:58.000Z
Bug: v8:10958 Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#92123}
diff --git a/src/execution/isolate.cc b/src/execution/isolate.cc
@@ -5644,6 +5644,20 @@ MaybeHandle<FixedArray> Isolate::GetImportAttributesFromArgument(
       // an error.
       return MaybeHandle<FixedArray>();
     }
+
+    if (V8_UNLIKELY(!IsUndefined(*import_attributes_object))) {
+      MessageLocation* location = nullptr;
+      MessageLocation computed_location;
+      if (ComputeLocation(&computed_location)) {
+        location = &computed_location;
+      }
+      Handle<JSMessageObject> message = MessageHandler::MakeMessageObject(
+          this, MessageTemplate::kImportAssertDeprecated, location,
+          factory()->NewStringFromAsciiChecked("12.6"),
+          Handle<FixedArray>::null());
+      message->set_error_level(v8::Isolate::kMessageWarning);
+      MessageHandler::ReportMessage(this, location, message);
+    }
   }
 
   // If there is no 'with' or 'assert' option in the options bag, it's not an
