[explicit-resource-management] Clear isolate internal exception

rmahdav · V8 LUCI CQ · commit 1d7159580156 · 2025-05-27T16:53:18.000-07:00
This CL clears the isolate internal exception before rejecting the promise. Bug: 418103036 Change-Id: If3748f7fc4b79b7b5be5009b9fff0d0267541a6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6594252 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Cr-Commit-Position: refs/heads/main@{#100532}
diff --git a/src/builtins/builtins-async-disposable-stack.cc b/src/builtins/builtins-async-disposable-stack.cc
@@ -89,10 +89,6 @@ BUILTIN(AsyncDisposeFromSyncDispose) {
               kMethod))),
       isolate);
 
-  v8::TryCatch try_catch(reinterpret_cast<v8::Isolate*>(isolate));
-  try_catch.SetVerbose(false);
-  try_catch.SetCaptureMessage(false);
-
   MaybeDirectHandle<Object> result =
       Execution::Call(isolate, sync_method, receiver, {});
 
@@ -107,7 +103,8 @@ BUILTIN(AsyncDisposeFromSyncDispose) {
       return {};
     }
     //        d. IfAbruptRejectPromise(result, promiseCapability).
-    DCHECK(try_catch.HasCaught());
+    isolate->clear_internal_exception();
+    isolate->clear_pending_message();
     JSPromise::Reject(promise, direct_handle(exception, isolate));
   }
 
diff --git a/test/inspector/debugger/break-on-exception-promise-catch-prediction-expected.txt b/test/inspector/debugger/break-on-exception-promise-catch-prediction-expected.txt
@@ -1133,7 +1133,7 @@ Correctly predicted as caught
 
 Running test: testCase
 > Throwing from throwInAsyncDisposeFormSync, handling with dontHandleAsync
-Paused on caught exception
+Paused on uncaught promiseRejection
 [Symbol.dispose] (catch-prediction.js:188:6)
 throwInAsyncDisposeFormSync (catch-prediction.js:185:18)
 dontHandleAsync (catch-prediction.js:196:8)
@@ -1171,7 +1171,7 @@ Correctly predicted as uncaught
 
 Running test: testCase
 > Throwing from throwInAsyncDisposeFormSync, handling with awaitAndCreateInTry
-Paused on caught exception
+Paused on caught promiseRejection
 [Symbol.dispose] (catch-prediction.js:188:6)
 throwInAsyncDisposeFormSync (catch-prediction.js:185:18)
 awaitAndCreateInTry (catch-prediction.js:202:10)
diff --git a/test/mjsunit/harmony/regress/regress-418103036.js b/test/mjsunit/harmony/regress/regress-418103036.js
@@ -0,0 +1,26 @@
+// Copyright 2025 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --ignore-unhandled-promises
+
+const obj = {
+  get f() {
+    async function f() {
+      function g() {
+        throw 1;
+      }
+      g[Symbol.dispose] = g;
+      await using y = g;
+    }
+    return f();
+  },
+};
+
+async function test(obj) {
+  const ser = d8.serializer.serialize(obj);
+  const des = d8.serializer.deserialize(ser);
+  await des;
+}
+
+assertThrowsAsync(test(obj), Error);
