[float16array] Turn flag on by default

syg · V8 LUCI CQ · commit 1d3362c55396 · 2025-05-06T15:12:05.000-07:00
Float16Array has shipped in blink since M135. It is unlikely it'll unship by now, so turn the flag on by default. Bug: 42203953 Change-Id: Ibd9de407b8810dd7bcdb46194fe04fc290ff8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513988 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100104}
diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h
@@ -294,8 +294,6 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
 // Features that are complete (but still behind the --harmony flag).
 #define HARMONY_STAGED_BASE(V)
 #define JAVASCRIPT_STAGED_FEATURES_BASE(V)                                   \
-  V(js_float16array,                                                         \
-    "Float16Array, Math.f16round, DataView.getFloat16, DataView.setFloat16") \
   V(js_base_64, "Uint8Array to/from base64 and hex")
 
 #ifdef V8_INTL_SUPPORT
@@ -320,7 +318,9 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
   V(js_atomics_pause, "Atomics.pause")                                 \
   V(js_error_iserror, "Error.isError")                                 \
   V(js_regexp_escape, "RegExp.escape")                                 \
-  V(js_explicit_resource_management, "explicit resource management")
+  V(js_explicit_resource_management, "explicit resource management")   \
+  V(js_float16array,                                                   \
+    "Float16Array, Math.f16round, DataView.getFloat16, DataView.setFloat16")
 
 #ifdef V8_INTL_SUPPORT
 #define HARMONY_SHIPPING(V) HARMONY_SHIPPING_BASE(V)
diff --git a/src/init/bootstrapper.cc b/src/init/bootstrapper.cc
@@ -5210,6 +5210,11 @@ DirectHandle<JSFunction> Genesis::InstallTypedArray(
           GetCorrespondingRabGsabElementsKind(elements_kind), 0);
   rab_gsab_initial_map->SetConstructor(*result);
 
+  if (rab_gsab_initial_map_index == Context::RAB_GSAB_FLOAT16_ARRAY_MAP_INDEX &&
+      v8_flags.js_float16array) {
+    LOG(isolate(), MapDetails(*rab_gsab_initial_map));
+  }
+
   native_context()->set(rab_gsab_initial_map_index, *rab_gsab_initial_map,
                         UPDATE_WRITE_BARRIER, kReleaseStore);
   Map::SetPrototype(isolate(), rab_gsab_initial_map, prototype);
diff --git a/test/test262/test262.status b/test/test262/test262.status
@@ -2383,7 +2383,6 @@
   'staging/sm/Temporal/PlainMonthDay/from-coptic': [FAIL],
   'staging/sm/Temporal/PlainMonthDay/from-gregory': [FAIL],
   'staging/sm/Temporal/PlainMonthDay/result-not-after-1972-dec-31': [FAIL],
-  'staging/sm/Math/f16round': [FAIL],
   'staging/sm/RegExp/unicode-ignoreCase': [FAIL],
   'staging/sm/String/string-code-point-upper-lower-mapping': [FAIL],
   'staging/sm/String/string-upper-lower-mapping': [FAIL],
@@ -2394,13 +2393,10 @@
   'staging/sm/TypedArray/prototype-constructor-identity': [FAIL],
   'staging/sm/TypedArray/set-detached-bigint': [FAIL],
   'staging/sm/TypedArray/seal-and-freeze': [FAIL],
-  'staging/sm/TypedArray/sort-negative-nan': [FAIL],
-  'staging/sm/TypedArray/sort_small': [FAIL],
   'staging/sm/TypedArray/test-integrity-level': [FAIL],
   'staging/sm/TypedArray/test-integrity-level-detached': [FAIL],
   'staging/sm/TypedArray/toReversed-detached': [FAIL],
   'staging/sm/TypedArray/toSorted-detached': [FAIL],
-  'staging/sm/TypedArray/toString': [FAIL],
   'staging/sm/TypedArray/with': [FAIL],
   'staging/sm/TypedArray/with-detached': [FAIL],
 }],
