Add MicrotasksPolicy parameter on MicrotaskQueue constructor

tzik · Commit Bot · commit 1b51dca30d69 · 2019-04-16T04:16:17.000Z
MicrotasksPolicy was a missing functionality of MicrotaskQueue that was available on the per-Isolate MicrotaskQueue. This expose that as a construction time option. Change-Id: I22bcc8082ca64552d107ee6db138011654047861 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559677 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#60858}
diff --git a/include/v8.h b/include/v8.h
@@ -6768,7 +6768,8 @@ class V8_EXPORT MicrotaskQueue {
   /**
    * Creates an empty MicrotaskQueue instance.
    */
-  static std::unique_ptr<MicrotaskQueue> New(Isolate* isolate);
+  static std::unique_ptr<MicrotaskQueue> New(
+      Isolate* isolate, MicrotasksPolicy policy = MicrotasksPolicy::kAuto);
 
   virtual ~MicrotaskQueue() = default;
 
diff --git a/src/api.cc b/src/api.cc
@@ -8935,8 +8935,12 @@ void v8::Isolate::LocaleConfigurationChangeNotification() {
 }
 
 // static
-std::unique_ptr<MicrotaskQueue> MicrotaskQueue::New(Isolate* isolate) {
-  return i::MicrotaskQueue::New(reinterpret_cast<i::Isolate*>(isolate));
+std::unique_ptr<MicrotaskQueue> MicrotaskQueue::New(Isolate* isolate,
+                                                    MicrotasksPolicy policy) {
+  auto microtask_queue =
+      i::MicrotaskQueue::New(reinterpret_cast<i::Isolate*>(isolate));
+  microtask_queue->set_microtasks_policy(policy);
+  return microtask_queue;
 }
 
 MicrotasksScope::MicrotasksScope(Isolate* isolate, MicrotasksScope::Type type)

Original file line number	Diff line number	Diff line change
`@@ -8935,8 +8935,12 @@ void v8::Isolate::LocaleConfigurationChangeNotification() {`
`8935`	`8935`	`}`
`8936`	`8936`
`8937`	`8937`	`// static`
`8938`		`-std::unique_ptr<MicrotaskQueue> MicrotaskQueue::New(Isolate* isolate) {`
`8939`		`- return i::MicrotaskQueue::New(reinterpret_cast<i::Isolate*>(isolate));`
	`8938`	`+std::unique_ptr<MicrotaskQueue> MicrotaskQueue::New(Isolate* isolate,`
	`8939`	`+ MicrotasksPolicy policy) {`
	`8940`	`+ auto microtask_queue =`
	`8941`	`+ i::MicrotaskQueue::New(reinterpret_cast<i::Isolate*>(isolate));`
	`8942`	`+ microtask_queue->set_microtasks_policy(policy);`
	`8943`	`+ return microtask_queue;`
`8940`	`8944`	`}`
`8941`	`8945`
`8942`	`8946`	`MicrotasksScope::MicrotasksScope(Isolate* isolate, MicrotasksScope::Type type)`