Fix build issue, remove unneeded include uchar.h.

Meir Shpilraien · V8 LUCI CQ · commit 1a3ecc2483b2 · 2023-09-05T09:23:35.000Z
Follow the conversation on: https://groups.google.com/g/v8-dev/c/nsbshwlmP3c. The `uchar.h` include is not necessary. It was added to get the definition of char16_t but that's an intrinsic type in C++. Change-Id: I0aaa11dba0be3ccad15b9e421f8bae71450d443b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4823404 Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/main@{#89787}
diff --git a/AUTHORS b/AUTHORS
@@ -194,6 +194,7 @@ Matt Hanselman <mjhanselman@gmail.com>
 Matthew Sporleder <msporleder@gmail.com>
 Maxim Mazurok <maxim@mazurok.com>
 Maxim Mossienko <maxim.mossienko@gmail.com>
+Meir Shpilraien <meir@redis.com>
 Michael Lutz <michi@icosahedron.de>
 Michael Mclaughlin <m8ch88l@gmail.com>
 Michael Smith <mike@w3.org>
diff --git a/src/inspector/string-16.h b/src/inspector/string-16.h
@@ -6,7 +6,6 @@
 #define V8_INSPECTOR_STRING_16_H_
 
 #include <stdint.h>
-#include <uchar.h>
 
 #include <cctype>
 #include <climits>
diff --git a/src/inspector/v8-string-conversions.h b/src/inspector/v8-string-conversions.h
@@ -5,7 +5,6 @@
 #ifndef V8_INSPECTOR_V8_STRING_CONVERSIONS_H_
 #define V8_INSPECTOR_V8_STRING_CONVERSIONS_H_
 
-#include <uchar.h>
 
 #include <cstdint>
 #include <string>

-Original file line number
+Diff line change
 Matthew Sporleder <[email protected]>
 Maxim Mazurok <[email protected]>
 Maxim Mossienko <[email protected]>
 +Meir Shpilraien <[email protected]>
 Michael Lutz <[email protected]>
 Michael Mclaughlin <[email protected]>
 Michael Smith <[email protected]>