Skip to content

Commit 16c10a6

Browse files
LiedtkeV8 LUCI CQ
authored andcommitted
[test] Replace std::format with std::stringstream
Unfortunately, the world (in this case third-party toolchains, but also our bazel configuration) isn't ready for it, yet. :) Change-Id: I7476d8a311f5425e72b184823bd70728bfacb666 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6586671 Reviewed-by: Milad Farazmand <[email protected]> Auto-Submit: Matthias Liedtke <[email protected]> Commit-Queue: Milad Farazmand <[email protected]> Cr-Commit-Position: refs/heads/main@{#100502}
1 parent 8c41ebb commit 16c10a6

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

test/unittests/wasm/function-body-decoder-unittest.cc

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
#include "src/wasm/function-body-decoder.h"
66

7+
#include <sstream>
8+
79
#include "src/flags/flags.h"
810
#include "src/utils/ostreams.h"
911
#include "src/wasm/canonical-types.h"
@@ -6375,7 +6377,11 @@ TEST_F(FunctionBodyDecoderTest, MemoryOrder) {
63756377
FunctionSig::Build(zone, {kWasmI32}, {array_i32, kWasmI32, kWasmI32});
63766378

63776379
for (uint8_t memory_order = 0; memory_order < 3; ++memory_order) {
6378-
SCOPED_TRACE(std::format("memory_order = {}", int{memory_order}));
6380+
// TODO(c++20): Replace with std::format once available on all compilers
6381+
// and build configurations.
6382+
std::stringstream str;
6383+
str << "memory_order = " << int{memory_order};
6384+
SCOPED_TRACE(str.str());
63796385
const bool valid = memory_order < 2;
63806386
// struct.atomic.get
63816387
Validate(valid, sig_struct_load_i32,

0 commit comments

Comments
 (0)