Repository navigation
Commit 1246d3b
[api] avoid applying IsGarbageCollectedType<void>
The updated version of http://crrev.com/c/8379082 was not enough
to remove the resolution of IsGarbageCollectedType<void>
which would hit the static_assert(sizeof(T)) assertion.
This patch explicitly rejects void again before checking the
trait.
Change-Id: Ieef4126bcba04e1e3c2bd62e89b7410a47cd2b29
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8411047
Reviewed-by: Leszek Swirski <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#109868}1 parent 9ecd741 commit 1246d3b
1 file changed
Lines changed: 7 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
328 | 329 | | |
329 | 330 | | |
330 | 331 | | |
331 | | - | |
| 332 | + | |
332 | 333 | | |
333 | 334 | | |
334 | 335 | | |
| |||
0 commit comments