Remove --js-promise-withresolvers runtime flag

anonrig · aduh95 · V8 LUCI CQ · commit 0d5d6e71bbb0 · 2024-09-20T21:49:13.000Z
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Bug: 42204122 Change-Id: I017a0d1ae0f8225513206ffb7806a4250be75d4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5843972 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Erik Corry <erikcorry@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#96215}
diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h
@@ -316,7 +316,6 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
   V(harmony_import_attributes, "harmony import attributes")
 
 #define JAVASCRIPT_SHIPPING_FEATURES_BASE(V)                           \
-  V(js_promise_withresolvers, "Promise.withResolvers")                 \
   V(js_regexp_duplicate_named_groups, "RegExp duplicate named groups") \
   V(js_regexp_modifiers, "RegExp modifiers")                           \
   V(js_promise_try, "Promise.try")
diff --git a/src/init/bootstrapper.cc b/src/init/bootstrapper.cc
@@ -3258,6 +3258,15 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
     InstallFunctionWithBuiltinId(isolate_, promise_fun, "reject",
                                  Builtin::kPromiseReject, 1, kAdapt);
 
+    std::array<Handle<Name>, 3> fields{factory->promise_string(),
+                                       factory->resolve_string(),
+                                       factory->reject_string()};
+    DirectHandle<Map> result_map =
+        CreateLiteralObjectMapFromCache(isolate_, fields);
+    native_context()->set_promise_withresolvers_result_map(*result_map);
+    InstallFunctionWithBuiltinId(isolate_, promise_fun, "withResolvers",
+                                 Builtin::kPromiseWithResolvers, 0, kAdapt);
+
     SetConstructorInstanceType(isolate_, promise_fun,
                                JS_PROMISE_CONSTRUCTOR_TYPE);
 
@@ -5581,24 +5590,6 @@ void Genesis::InitializeGlobal_js_promise_try() {
                                Builtin::kPromiseTry, 1, kDontAdapt);
 }
 
-void Genesis::InitializeGlobal_js_promise_withresolvers() {
-  if (!v8_flags.js_promise_withresolvers) return;
-
-  Factory* factory = isolate()->factory();
-
-  std::array<Handle<Name>, 3> fields{factory->promise_string(),
-                                     factory->resolve_string(),
-                                     factory->reject_string()};
-  DirectHandle<Map> result_map =
-      CreateLiteralObjectMapFromCache(isolate(), fields);
-  native_context()->set_promise_withresolvers_result_map(*result_map);
-
-  Handle<JSFunction> promise_fun =
-      handle(native_context()->promise_function(), isolate());
-  InstallFunctionWithBuiltinId(isolate(), promise_fun, "withResolvers",
-                               Builtin::kPromiseWithResolvers, 0, kAdapt);
-}
-
 void Genesis::InitializeGlobal_harmony_set_methods() {
   if (!v8_flags.harmony_set_methods) return;
 
diff --git a/test/mjsunit/harmony/promise-withresolvers.js b/test/mjsunit/harmony/promise-withresolvers.js
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --js-promise-withresolvers --allow-natives-syntax
+// Flags: --allow-natives-syntax
 
 const desc = Object.getOwnPropertyDescriptor(Promise, 'withResolvers');
 assertTrue(desc.configurable);
diff --git a/test/test262/testcfg.py b/test/test262/testcfg.py
@@ -58,7 +58,6 @@
     'json-parse-with-source': '--harmony-json-parse-with-source',
     'iterator-helpers': '--harmony-iterator-helpers',
     'set-methods': '--harmony-set-methods',
-    'promise-with-resolvers': '--js-promise-withresolvers',
     'import-attributes': '--harmony-import-attributes',
     'regexp-duplicate-named-groups': '--js-regexp-duplicate-named-groups',
     'regexp-modifiers': '--js-regexp-modifiers',
