Extending v8::GetHeapStatistics to return total available size.

ssiddhartha · Commit bot · commit 0a1352a716e9 · 2015-04-28T10:57:15.000Z
For dumping memory statistics about v8 heap, we need the total available size of the heap. This CL adds extra field in HeapStatistics to return the available size. BUG=476013 LOG=Y Review URL: https://codereview.chromium.org/1104123002 Cr-Commit-Position: refs/heads/master@{#28100}
diff --git a/include/v8.h b/include/v8.h
@@ -4776,13 +4776,15 @@ class V8_EXPORT HeapStatistics {
   size_t total_heap_size() { return total_heap_size_; }
   size_t total_heap_size_executable() { return total_heap_size_executable_; }
   size_t total_physical_size() { return total_physical_size_; }
+  size_t total_available_size() { return total_available_size_; }
   size_t used_heap_size() { return used_heap_size_; }
   size_t heap_size_limit() { return heap_size_limit_; }
 
  private:
   size_t total_heap_size_;
   size_t total_heap_size_executable_;
   size_t total_physical_size_;
+  size_t total_available_size_;
   size_t used_heap_size_;
   size_t heap_size_limit_;
 
diff --git a/src/api.cc b/src/api.cc
@@ -6871,6 +6871,7 @@ void Isolate::GetHeapStatistics(HeapStatistics* heap_statistics) {
   heap_statistics->total_heap_size_executable_ =
       heap->CommittedMemoryExecutable();
   heap_statistics->total_physical_size_ = heap->CommittedPhysicalMemory();
+  heap_statistics->total_available_size_ = heap->Available();
   heap_statistics->used_heap_size_ = heap->SizeOfObjects();
   heap_statistics->heap_size_limit_ = heap->MaxReserved();
 }

Original file line number	Diff line number	Diff line change
`@@ -6871,6 +6871,7 @@ void Isolate::GetHeapStatistics(HeapStatistics* heap_statistics) {`
`6871`	`6871`	`heap_statistics->total_heap_size_executable_ =`
`6872`	`6872`	`heap->CommittedMemoryExecutable();`
`6873`	`6873`	`heap_statistics->total_physical_size_ = heap->CommittedPhysicalMemory();`
	`6874`	`+ heap_statistics->total_available_size_ = heap->Available();`
`6874`	`6875`	`heap_statistics->used_heap_size_ = heap->SizeOfObjects();`
`6875`	`6876`	`heap_statistics->heap_size_limit_ = heap->MaxReserved();`
`6876`	`6877`	`}`