[cfi] Add missing 'typename' in SegmentedTable

targos · V8 LUCI CQ · commit 01a47f3ffff2 · 2024-08-26T11:49:05.000Z
Makes the code more consistent and fixes compilation on older Clang versions. Change-Id: I82abebd500e6651ac5c5b180cd7b49b4f20e8299 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5805956 Reviewed-by: Samuel Groß <saelo@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Reviewed-by: Stephen Röttger <sroettger@google.com> Cr-Commit-Position: refs/heads/main@{#95809}
diff --git a/src/common/segmented-table-inl.h b/src/common/segmented-table-inl.h
@@ -113,7 +113,7 @@ void SegmentedTable<Entry, size>::TearDown() {
 }
 
 template <typename Entry, size_t size>
-SegmentedTable<Entry, size>::FreelistHead
+typename SegmentedTable<Entry, size>::FreelistHead
 SegmentedTable<Entry, size>::InitializeFreeList(Segment segment,
                                                 uint32_t start_offset) {
   DCHECK_LT(start_offset, kEntriesPerSegment);

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ void SegmentedTable<Entry, size>::TearDown() {`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`template <typename Entry, size_t size>`
`116`		`-SegmentedTable<Entry, size>::FreelistHead`
	`116`	`+typename SegmentedTable<Entry, size>::FreelistHead`
`117`	`117`	`SegmentedTable<Entry, size>::InitializeFreeList(Segment segment,`
`118`	`118`	`uint32_t start_offset) {`
`119`	`119`	`DCHECK_LT(start_offset, kEntriesPerSegment);`