[conversions] Check for denormal flushing in DoubleToRadixString

LeszekSwirski · V8 LUCI CQ · commit 00b8fba79ed2 · 2025-02-20T06:12:43.000-08:00
Explicitly check the denormal flushing flag in DoubleToRadixString, to avoid the compiler optimizing away checks against zero. Bug: 382005099 Fixed: 397731718 Change-Id: If9298e68827bf2e5a1fd987b04b2536bf937a19f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6286167 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#98833}
diff --git a/src/numbers/conversions.cc b/src/numbers/conversions.cc
@@ -1251,11 +1251,19 @@ std::string_view DoubleToRadixStringView(double value, int radix,
   double fraction = value - integer;
   // We only compute fractional digits up to the input double's precision.
   double delta = 0.5 * (base::Double(value).NextDouble() - value);
-  delta = std::max(base::Double(0.0).NextDouble(), delta);
-  // Delta should always be greater than zero, so long as we're not flushing
-  // denormals to zero.
-  DCHECK_IMPLIES(!(delta > 0.0), base::FPU::GetFlushDenormals());
-  if (delta > 0.0 && fraction >= delta) {
+  bool delta_is_positive = true;
+  // If the delta rounded down to zero, use the minimum (denormal) delta
+  // value. Be careful around denormal flushing when doing so.
+  if (delta <= 0) {
+    if (base::FPU::GetFlushDenormals()) {
+      // We're flushing the delta value to zero, so the loop below won't
+      // make progress. Skip it instead.
+      delta_is_positive = false;
+    } else {
+      delta = base::Double(0.0).NextDouble();
+    }
+  }
+  if (delta_is_positive && fraction >= delta) {
     // Insert decimal point.
     buffer[fraction_cursor++] = '.';
     do {
