avoid DNS leakage with gRPC transports#3587
Merged
xiaokangwang merged 1 commit intov2fly:masterfrom Jan 14, 2026
Merged
Conversation
Signed-off-by: Leo <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3587 +/- ##
=======================================
Coverage 23.20% 23.21%
=======================================
Files 836 836
Lines 45442 45442
=======================================
+ Hits 10547 10549 +2
+ Misses 33678 33677 -1
+ Partials 1217 1216 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiaokangwang
approved these changes
Jan 14, 2026
Contributor
xiaokangwang
left a comment
xiaokangwang
left a comment
There was a problem hiding this comment.
Thanks! This pull request is ready for merge.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, v2ray queries TXT record for domain formats in
_grpc_config.<invalid.test>when gRPC transport is used, this could potentially being exploited by censorships as an indicator.despite this behaviour is a part of standard and is the current best practice mandated by grpc developers, according to https://github.com/grpc/proposal/blob/master/A2-service-configs-in-dns.md#encoding-in-dns-txt-records, while considering its potential degradation to protocol "stealthiness", this patch disables this behaviour by appending a
DialOptionreturned bygrpc.WithDisableServiceConfig().