Add cosine distance algorithm#3248
Merged
ahuber21 merged 230 commits intouxlfoundation:mainfrom Jul 31, 2025
Merged
Conversation
Signed-off-by: North Iii <[email protected]>
Signed-off-by: North Iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: North Iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…foundation#3276) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alexander Andreev <[email protected]>
* Adds correlation distance algorithm, examples, docs, and unit tests Signed-off-by: North Iii <[email protected]> Co-authored-by: Victoriya Fedotova <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
Signed-off-by: richard.north.iii <[email protected]>
…3278) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* set init pointer to null * disambiguate references to global object and instantiated object
* Added SVE intrinsics for postGemm function * Removed SVE implementation of float exponential due to accuracy issues * Format code using clang-format --------- Co-authored-by: shubham.chaudhari <[email protected]>
…h3/oneDAL into dev/cosine-dist-algo Signed-off-by: richard.north.iii <[email protected]>
Contributor
Author
|
/intelci: run |
Contributor
Author
|
/intelci: run |
Contributor
Author
|
@ahuber21 could you approve your requested changes so this PR can be merged in? |
Vika-F
reviewed
Jul 16, 2025
| } | ||
| else if (na == 2) | ||
| { | ||
| NumericTable * yTable = const_cast<NumericTable *>(a[1]); /* y Input data */ |
Contributor
There was a problem hiding this comment.
Suggested change
| NumericTable * yTable = const_cast<NumericTable *>(a[1]); /* y Input data */ | |
| const NumericTable * yTable = a[1]; /* y Input data */ |
Contributor
There was a problem hiding this comment.
Similar changes can be done in the lines 60, 61:
const NumericTable * xTable = a[0]; /* Input data */
NumericTable * rTable = r[0]; /* Output data */
Contributor
There are still some things that need to be addressed. See Vika's comments. |
Contributor
Author
Vika-F
added a commit
to Vika-F/daal
that referenced
this pull request
Aug 1, 2025
Add cosine distance algorithm (uxlfoundation#3248)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the cosine distance algorithm for both the DAAL and oneDAL frameworks, computing pairwise cosine distances between feature vectors. The DAAL implementation includes block-based, batch processing containers, and complete user documentation. The oneDAL implementation adds GPU offload with SYCL/DPC++ support through compute kernels for both CPU and GPU backends, comprehensive test cases for both CPU and GPU, bazel build integration, and updated documentation with mathematical specifications and API references.
PR completeness and readability
Testing