[CI] use sklearnex azure pipelines template for sklearnex CI step#2950
Merged
icfaust merged 45 commits intouxlfoundation:mainfrom Dec 10, 2024
Merged
[CI] use sklearnex azure pipelines template for sklearnex CI step#2950icfaust merged 45 commits intouxlfoundation:mainfrom
icfaust merged 45 commits intouxlfoundation:mainfrom
Conversation
icfaust
requested review from
Alexsandruss,
ahuber21,
ethanglaser,
homksei and
napetrov
as code owners
Contributor
Author
|
/intelci: run |
13 tasks
Contributor
Author
|
/intelci: run |
homksei
approved these changes
Dec 9, 2024
| function install_mkl { | ||
| sudo apt-get install -y intel-oneapi-mkl-devel-2025.0 intel-oneapi-tbb-devel-2022.0 | ||
| sudo apt-get install -y intel-oneapi-mkl-devel-2025.0 | ||
| install_tbb |
Contributor
There was a problem hiding this comment.
should it be called here? May be its better to call both functions? And why we must include it in MKL?
Contributor
Author
There was a problem hiding this comment.
Good question @Alexandr-Solovev, why tbb install was included in mkl I do not know (included in the 2025.0 update I think), but I called one function in the other so that we only have to change the tbb version in one location going forward. Let me know if I should change it.
Contributor
There was a problem hiding this comment.
current changes look good for me
Alexandr-Solovev
approved these changes
Dec 10, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
oneDAL should refer to sklearnex's testing rather than storing scripts on its own locally. This is a maintenance burden that we can remove. No performance benchmarks are necessary. This PR has been enabled by uxlfoundation/scikit-learn-intelex#2125 in order to use the PR-generated GNUMKL build.
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance