Skip to content

tail: fix intermittent overlay-headers test by batching inotify events #9598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 2 commits into from
Dec 10, 2025
Merged

tail: fix intermittent overlay-headers test by batching inotify events #9598

cakebaker merged 2 commits into from
Dec 10, 2025

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Dec 7, 2025

No description provided.

@ChrisDryden
Copy link
Contributor

ChrisDryden commented Dec 7, 2025

Major QOL improvement! Kudos
Screenshot 2025-12-07 at 12 03 34 PM

@sylvestre
Copy link
Contributor Author

sylvestre commented Dec 7, 2025

i hope :)
i failed the first time

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9598 will degrade performances by 3.51%

Comparing sylvestre:tail-intermittent-2 (adafa2f) with main (67ede85)

Summary

❌ 1 regression
✅ 126 untouched
⏩ 6 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ tsort_input_parsing_heavy[5000] 82.7 ms 85.7 ms -3.51%

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre force-pushed the tail-intermittent-2 branch from 30fbd8d to adafa2f Compare December 8, 2025 06:59
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/stty/stty-invalid is now passing!
Congrats! The gnu test tests/stty/stty-pairs is now passing!
Note: The gnu test tests/mv/i-3 was skipped on 'main' but is now failing.
Note: The gnu test tests/stty/stty was skipped on 'main' but is now failing.
Note: The gnu test tests/stty/stty-row-col was skipped on 'main' but is now failing.

@cakebaker cakebaker merged commit 911fc92 into uutils:main Dec 10, 2025
185 of 188 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Dec 10, 2025

Let's try again :)

@moonfruit moonfruit mentioned this pull request Dec 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sylvestre @ChrisDryden @cakebaker