cksum: small improvements, l10n #9532

RenjiSann · 2025-12-01T00:05:45Z

This MR brings a few changes to simplify and optimize some parts of the checksum computation

It depends on the #9511 MR

github-actions · 2025-12-01T00:32:57Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-c is no longer failing!

codspeed-hq · 2025-12-01T02:12:46Z

CodSpeed Performance Report

Merging #9532 will degrade performances by 16.39%

_{Comparing RenjiSann:cksum-improvements (ad13266) with main (22a8732)}

Summary

⚡ 1 improvement
❌ 13 regressions
✅ 112 untouched
⏩ 6 skipped¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
❌	`wc_bytes_synthetic[500]`	163.9 µs	182.4 µs	-10.16%
❌	`cksum_blake3`	190.7 µs	207.7 µs	-8.17%
❌	`b64_decode_ignore_garbage_synthetic`	149.2 µs	166.8 µs	-10.51%
❌	`b64_decode_synthetic`	149.1 µs	168.8 µs	-11.72%
❌	`b64_encode_synthetic`	146.3 µs	164.4 µs	-11.03%
⚡	`sort_ascii_c_locale`	22.7 ms	21.7 ms	+4.51%
❌	`sort_reverse_mixed`	38.2 ms	39.2 ms	-2.57%
❌	`ls_recursive_wide_tree[(10000, 1000)]`	51.3 ms	52.5 ms	-2.33%
❌	`mv_single_file`	129.7 ms	136 ms	-4.6%
❌	`mv_force_overwrite`	125.3 ms	138.4 ms	-9.47%
❌	`cp_large_file[16]`	341.3 µs	358.5 µs	-4.8%
❌	`split_number_chunks`	275.4 µs	287.7 µs	-4.27%
❌	`rm_single_file`	106.6 ms	119.6 ms	-10.89%
❌	`factor_multiple_u64s[2]`	178.3 ms	213.2 ms	-16.39%

6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-12-01T02:28:07Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum-c is no longer failing!

github-actions · 2025-12-01T10:56:05Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-c is no longer failing!

github-actions · 2025-12-01T18:49:10Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

RenjiSann · 2025-12-03T10:05:08Z

It looks like the localized messages I added add a significant overhead to many other tools :/ Not sure how to improve this.

tests/by-util/test_cksum.rs

src/uucore/src/lib/features/checksum/compute.rs

src/uucore/src/lib/features/checksum/validate.rs

github-actions · 2025-12-04T13:40:34Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

src/uucore/src/lib/features/sum.rs

src/uucore/src/lib/features/checksum/validate.rs

cakebaker

Done :)

github-actions · 2025-12-04T23:23:32Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

... to prevent a preemptive computation of the hex encoding.

…um_format

to avoid decoding base64 and directly re-encoding it in hexadecimal

…-input filename print

RenjiSann · 2025-12-05T00:12:54Z

Done :)

Thanks, I had forgotten many things ^^'

github-actions · 2025-12-05T00:27:12Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

cakebaker · 2025-12-05T08:18:20Z

Thanks :)

RenjiSann self-assigned this Dec 1, 2025

RenjiSann force-pushed the cksum-improvements branch from 5461873 to c6b9693 Compare December 1, 2025 01:59

RenjiSann changed the title ~~cksum: small improvements~~ cksum: small improvements, l10n Dec 1, 2025

RenjiSann force-pushed the cksum-improvements branch from c6b9693 to be080a2 Compare December 1, 2025 02:12

RenjiSann force-pushed the cksum-improvements branch 2 times, most recently from 4e9151b to 086d610 Compare December 1, 2025 10:40

RenjiSann mentioned this pull request Dec 1, 2025

cksum: Fix GNU test cksum-c.sh after bump to 9.9 #9511

Merged

RenjiSann force-pushed the cksum-improvements branch 2 times, most recently from c96ed79 to dc8063d Compare December 1, 2025 18:32

RenjiSann marked this pull request as ready for review December 3, 2025 10:05