stty: Implemented saved state parser for stty #9480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDryden
changed the title
|
GNU testsuite comparison: |
sylvestre
reviewed
Nov 25, 2025
sylvestre
reviewed
Nov 25, 2025
sylvestre
reviewed
Nov 25, 2025
…lity checks and documentation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
Author
|
The new testing I added brought up an issue that the GNU tests are being skipped without error if the version of GNU is not high enough, this likely causes blind spots in our CI testing and should be fixed. I thought everything was matching the GNU implementation until I upgraded the GNU version and discovered that the messaging was quite different. |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
… from a LIBC value
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #9480 will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
Contributor
Author
|
Its a bit tough to figure out what the full scope of this PR should be, now that we have the integ tests running on many platforms I am discovering that various parts of the program are not matching the GNU implementation. I am going to try to disable the tests that are failing for reasons that aren't related to the state parsing but instead the flag printing and plan on following up on adding more testing and fixing the bugs in following PR's since this is already over 200 lines |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
This was referenced Nov 27, 2025
RenjiSann
pushed a commit
to RenjiSann/coreutils
that referenced
this pull request
Nov 28, 2025
* Implemented saved state parser for stty * Add compatibility to macos flag type * Added many example state parsing integration tests with GNU compatibility checks and documentation * Spelling and formatting fixes * Matching behaviour of adding the help command after invocations and spelling fixes * GNU tests were being skipped because they were not at the sufficient version * Fixed messaging error for invalid states to not show full path * Normalizing the test output and reverting lib change * Discovered that the limit depends on platform specific values derived from a LIBC value * Spelling fixes and setting flags to 0 for cross platform compatibility * Clippy fixes * Disabling tests due to invalid printing of control chars and using GNU for printing * Redisabling failing test as outside of the scope of this PR * Adding g prefix support to normalize stderr * Spell checker fixes * Normalizing command for both gnu and uutils output * removing single value from testing since it can be interpreted as Baud rate * Fixing spelling mistake
martinkunkel2
pushed a commit
to martinkunkel2/coreutils
that referenced
this pull request
Nov 30, 2025
* Implemented saved state parser for stty * Add compatibility to macos flag type * Added many example state parsing integration tests with GNU compatibility checks and documentation * Spelling and formatting fixes * Matching behaviour of adding the help command after invocations and spelling fixes * GNU tests were being skipped because they were not at the sufficient version * Fixed messaging error for invalid states to not show full path * Normalizing the test output and reverting lib change * Discovered that the limit depends on platform specific values derived from a LIBC value * Spelling fixes and setting flags to 0 for cross platform compatibility * Clippy fixes * Disabling tests due to invalid printing of control chars and using GNU for printing * Redisabling failing test as outside of the scope of this PR * Adding g prefix support to normalize stderr * Spell checker fixes * Normalizing command for both gnu and uutils output * removing single value from testing since it can be interpreted as Baud rate * Fixing spelling mistake
martinkunkel2
pushed a commit
to martinkunkel2/coreutils
that referenced
this pull request
Nov 30, 2025
* Implemented saved state parser for stty * Add compatibility to macos flag type * Added many example state parsing integration tests with GNU compatibility checks and documentation * Spelling and formatting fixes * Matching behaviour of adding the help command after invocations and spelling fixes * GNU tests were being skipped because they were not at the sufficient version * Fixed messaging error for invalid states to not show full path * Normalizing the test output and reverting lib change * Discovered that the limit depends on platform specific values derived from a LIBC value * Spelling fixes and setting flags to 0 for cross platform compatibility * Clippy fixes * Disabling tests due to invalid printing of control chars and using GNU for printing * Redisabling failing test as outside of the scope of this PR * Adding g prefix support to normalize stderr * Spell checker fixes * Normalizing command for both gnu and uutils output * removing single value from testing since it can be interpreted as Baud rate * Fixing spelling mistake
romanstingler
pushed a commit
to romanstingler/coreutils
that referenced
this pull request
Dec 14, 2025
* Implemented saved state parser for stty * Add compatibility to macos flag type * Added many example state parsing integration tests with GNU compatibility checks and documentation * Spelling and formatting fixes * Matching behaviour of adding the help command after invocations and spelling fixes * GNU tests were being skipped because they were not at the sufficient version * Fixed messaging error for invalid states to not show full path * Normalizing the test output and reverting lib change * Discovered that the limit depends on platform specific values derived from a LIBC value * Spelling fixes and setting flags to 0 for cross platform compatibility * Clippy fixes * Disabling tests due to invalid printing of control chars and using GNU for printing * Redisabling failing test as outside of the scope of this PR * Adding g prefix support to normalize stderr * Spell checker fixes * Normalizing command for both gnu and uutils output * removing single value from testing since it can be interpreted as Baud rate * Fixing spelling mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A missing feature in the implementation currently is the ability to read values that look like the format:
Apart from this, is the last feature missing for stty for the main stty test is the COLUMN env var. I implemented three integ tests for this new code that matches the types of tests that are run in the stty GNU tests.
This ended up being way more complicated than I originally envisioned after I had set up the GNU comparisons to run in the integration tests across multiple platforms. I learned that the amount of control flags is actually determined by a LIBC variable and that the GNU implementation had additional error messaging associated with the arg parsing error messages that we were not adding.
There is also still an pre-existing issue where the output of the control flag state is not being printed correctly, so for me to add an integration test to compare the printed output of the save state between GNU and the UUTILS implementation I will have to wait until that issue is addressed. Its already starting to become a long PR so was hoping to create this one to purely focus on the state saving and then can address the printing issues and flags in other PR's since it might involve upstream NIX changes.