Improve the `stty --all` output to match GNU version #9432

3v1n0 · 2025-11-21T03:39:22Z

The output of stty --all was not really matching GNU one, adjust it to follow the same logic

Before:

--- /tmp/gnu-stty	2025-11-21 01:41:14.909020716 +0100
+++ /tmp/rust-stty	2025-11-21 00:38:42.324215733 +0100
@@ -1,10 +1,6 @@
-speed 38400 baud; rows 57; columns 112; line = 0;
-intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = <undef>;
-eol2 = <undef>; swtch = <undef>; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R;
-werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
--parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts
--ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff
--iuclc -ixany -imaxbel iutf8
-opost -olcuc -ocrnl onlcr -onocr -onlret -ofill -ofdel nl0 cr0 tab0 bs0 vt0 ff0
-isig icanon iexten echo echoe echok -echonl -noflsh -xcase -tostop -echoprt
-echoctl echoke -flusho -extproc
+speed 38400 baud; rows 57; columns 115; line = 0;
+intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = <undef>; eol2 = <undef>; swtch = <undef>; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R; werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
+-parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts 
+-ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl -ixoff -tandem ixon -ixany -imaxbel iutf8 
+opost -olcuc -ocrnl onlcr -onocr -onlret -ofdel nl0 cr0 tab0 bs0 vt0 ff0 
+isig icanon iexten echo echoe echok -echonl -noflsh -tostop -echoprt echoctl echoke -flusho -extpro```

After:

--- /tmp/gnu-stty	2025-11-21 01:41:14.909020716 +0100
+++ /tmp/rust-stty	2025-11-21 04:31:16.511313289 +0100
@@ -4,7 +4,7 @@
 werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
 -parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts
 -ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff
--iuclc -ixany -imaxbel iutf8
-opost -olcuc -ocrnl onlcr -onocr -onlret -ofill -ofdel nl0 cr0 tab0 bs0 vt0 ff0
-isig icanon iexten echo echoe echok -echonl -noflsh -xcase -tostop -echoprt
-echoctl echoke -flusho -extproc
+-ixany -imaxbel iutf8
+opost -olcuc -ocrnl onlcr -onocr -onlret -ofdel nl0 cr0 tab0 bs0 vt0 ff0
+isig icanon iexten echo echoe echok -echonl -noflsh -tostop -echoprt echoctl
+echoke -flusho -extproc

Highlight is not great for word diffing, but well:

❯ wdiff /tmp/stty-out /tmp/rstty-out 
speed 38400 baud; rows 57; columns 112; line = 0;
intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = <undef>;
eol2 = <undef>; swtch = <undef>; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R;
werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
-parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts
-ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff
[--iuclc-]
-ixany -imaxbel iutf8
opost -olcuc -ocrnl onlcr -onocr -onlret [--ofill-] -ofdel nl0 cr0 tab0 bs0 vt0 ff0
isig icanon iexten echo echoe echok -echonl -noflsh [--xcase-] -tostop -echoprt echoctl
echoke -flusho -extpro

After the flags we're missing will be included upstream, the diff will be actually none.

github-actions · 2025-11-21T05:59:56Z

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-base64-untagged. tests/cksum/cksum-base64-untagged is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-21T06:33:32Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-21T07:14:24Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64-untagged is no longer failing!

github-actions · 2025-11-21T07:48:56Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64-untagged is no longer failing!

ChrisDryden · 2025-11-21T18:49:39Z

src/uu/stty/src/flags.rs

+    // Status character
+    // ("status", S::VSTATUS), // Not supported by nix
+    // Minimum number of characters for noncanonical read.
+    // ("min", S::VMIN),


Is it possible that the nix compatibility is more about the platform that it is being built on?

I checked the code, but there are no such definitions... I wanted to submit a change there too, but I'm unsure about what platforms are supported, so I'd rather wait for someone having it to support it

for this specific case, actually it was defined, but I commented this out since we use the value differently in the code

ChrisDryden · 2025-11-21T18:49:50Z

src/uu/stty/src/flags.rs

        target_os = "macos"
    ))]
+    // Not supported by nix.
+    // Flag::new("ofill", O::OFILL),


Is this a typo?

I mean... https://github.com/coreutils/coreutils/blob/master/src/stty.c#L268

added to nix-rust/nix#2701 also

Related to: uutils/coreutils#9432

3v1n0 · 2025-11-21T22:06:25Z

src/uu/stty/src/flags.rs

+    Flag::new("ixoff", I::IXOFF),
+    Flag::new("tandem", I::IXOFF).hidden(),
    // not supported by nix
    // Flag::new("iuclc", I::IUCLC),


Not related to this PR, but this is being added to libc rust-lang/libc#4846 then we need to update nix

github-actions · 2025-11-21T22:55:54Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

Related to: uutils/coreutils#9432

github-actions · 2025-11-22T06:11:17Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-22T15:51:35Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

ChrisDryden · 2025-11-24T18:04:55Z

For making this easier to review for the maintainers, do you think it would be possible to split the Flag updates and the column env variable and printer?

Recently the ability for the integration tests in test_stty are able to run on the CI and if it would be possible could you create a test for the column output showing it working?

3v1n0 · 2025-11-24T18:08:05Z

Recently the ability for the integration tests in test_stty are able to run on the CI and if it would be possible could you create a test for the column output showing it working?

Yeah, I was considering it in fact now that there is such support indeed... I was wondering also if doing GNU core-utils comparisons would make sense, but it cannot be done in a static way since the values may change, but a proper test would be runnig tty --all with both tools in the same environment and compare them, but I'm unsure how this can be achieved.

3v1n0 · 2025-11-24T18:09:07Z

do you think it would be possible to split the Flag updates and the column env variable and printer?

Yeah, they are already in different commits. In fact I was expecting the PR to be reviewed considering each commit as atomic, but I can split it out if you prefer to have different PRs instead (I know github per-commit review workflow is far away from the good that it is in gitlab)

ChrisDryden · 2025-11-24T18:11:12Z

#9338 I have some more details in here about some of the GNU current incompatibilities, there is a test in the GNU test suite that tests the COLUMN env variable and maybe replicating that would be the best way to do it

ChrisDryden · 2025-11-24T19:07:06Z

This is an output agnostic way to test it thats used in the GNU test suite, that we're looking to have compatibility with

# Ensure we wrap output appropriately
for W in $(seq 80 90); do
  output_width=$(COLUMNS="$W" stty -a | wc -L)
  test "$output_width" -le "$W" || fail=1
done

SteveLauC · 2025-11-25T05:21:46Z

Hi, I come from nix-rust/nix, let me know if you need nix to drop a release when those PRs get merged

3v1n0 · 2025-11-25T09:44:57Z

Hi, I come from nix-rust/nix, let me know if you need nix to drop a release when those PRs get merged

We can probably wait until the libc missing stuff has landed too

ChrisDryden · 2025-11-25T18:21:12Z

Mind if I cherry-pick that first commit of yours to a new pr and add another commit for adding the integ tests for that commit? I'm just particularly focused on that env COLUMNS portion of the PR since after the saved state parser its the only thing missing to make a few of the STTY GNU tests pass.

3v1n0 · 2025-11-25T19:20:14Z

Mind if I cherry-pick that first commit of yours to a new pr and add another commit for adding the integ tests for that commit? I'm just particularly focused on that env COLUMNS portion of the PR since after the saved state parser its the only thing missing to make a few of the STTY GNU tests pass.

Sure, feel free

* termios: Add OFILL Related to: uutils/coreutils#9432 * changelog * typo: Android --------- Co-authored-by: Steve Lau <[email protected]>

SteveLauC · 2025-11-26T01:33:17Z

Hi, I come from nix-rust/nix, let me know if you need nix to drop a release when those PRs get merged

We can probably wait until the libc missing stuff has landed too

Yeah, nix PRs depend on those libc PRs

Do the same as GNU stty when it has to prints the parameter, doing proper text wrapping

It is just an alias for ixoff, and it's marked with `OMIT` in GNU version

Now the order is respected

It's only supported by BSD, aix and solaris, but still available in nix

List the remaining flags that GNU stty support, they cannot be be listed yet since we have no nix support for them, but it's better to keep the lists in sync so that it's easier to enable what will be supported in future

This is going to be supported via those PRs, so let's track them to make it easier to support it in future

Until nix won't include it we can safely just rely on the libc definition

Nix now supports the line discipline parameter in various platforms, so use upstream definition instead of going through libc See: nix-rust/nix#1802

3v1n0 force-pushed the stty-better-printing branch 2 times, most recently from b287c72 to 9c6d77f Compare November 21, 2025 06:33

3v1n0 force-pushed the stty-better-printing branch 2 times, most recently from 46cbbc3 to b989937 Compare November 21, 2025 06:57

3v1n0 force-pushed the stty-better-printing branch from b989937 to bae055d Compare November 21, 2025 07:32

ChrisDryden reviewed Nov 21, 2025

View reviewed changes

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 21, 2025

termios: Add OFILL

87ef7ef

Related to: uutils/coreutils#9432

3v1n0 mentioned this pull request Nov 21, 2025

termios: Add OFILL nix-rust/nix#2701

Merged

3 tasks

3v1n0 force-pushed the stty-better-printing branch from bae055d to 173ad5a Compare November 21, 2025 22:04

3v1n0 commented Nov 21, 2025

View reviewed changes

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 21, 2025

termios: Add definition for IUCLC

86c7019

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 21, 2025

termios: Add definition for XCASE

ea42111

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

This was referenced Nov 21, 2025

termios: Add definition for XCASE nix-rust/nix#2703

Draft

termios: Add definition for IUCLC nix-rust/nix#2702

Draft

3v1n0 force-pushed the stty-better-printing branch from 173ad5a to 65b5c7a Compare November 21, 2025 23:57

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 22, 2025

termios: Add OFILL

a245fc7

Related to: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 22, 2025

termios: Add OFILL

9f1304c

Related to: uutils/coreutils#9432

3v1n0 force-pushed the stty-better-printing branch 5 times, most recently from 704772b to fa39e80 Compare November 22, 2025 04:00

sylvestre force-pushed the stty-better-printing branch from f0de189 to 61ce79b Compare November 22, 2025 08:12

github-merge-queue bot pushed a commit to nix-rust/nix that referenced this pull request Nov 26, 2025

termios: Add OFILL (#2701)

984420e

* termios: Add OFILL Related to: uutils/coreutils#9432 * changelog * typo: Android --------- Co-authored-by: Steve Lau <[email protected]>

ChrisDryden mentioned this pull request Nov 26, 2025

stty: columns env support and integration testing #9490

Open

3v1n0 added 9 commits December 6, 2025 14:45

stty: Wrap parameters when using --all

518754d

Do the same as GNU stty when it has to prints the parameter, doing proper text wrapping

stty/flags: Do not show tandem option

803c06e

It is just an alias for ixoff, and it's marked with `OMIT` in GNU version

stty/flags: Use same order of GNU in printing ixoff/ixon

7adcb37

Now the order is respected

stty/flags: Add missing tabs combination setting

478c445

stty/flags: Add delayed suspend (dsusp) support

6e90d12

It's only supported by BSD, aix and solaris, but still available in nix

stty/flags: List all missing flags that GNU version supports

5049ad4

List the remaining flags that GNU stty support, they cannot be be listed yet since we have no nix support for them, but it's better to keep the lists in sync so that it's easier to enable what will be supported in future

stty/flags: Add references to support to IUCLC

e84fc9e

This is going to be supported via those PRs, so let's track them to make it easier to support it in future

stty: Use libc definition for OFILL

4d3b4b9

Until nix won't include it we can safely just rely on the libc definition

stty: Use c_line (as line_discipline) from nix

e6e285a

Nix now supports the line discipline parameter in various platforms, so use upstream definition instead of going through libc See: nix-rust/nix#1802

sylvestre force-pushed the stty-better-printing branch from 61ce79b to e6e285a Compare December 6, 2025 13:45

Uh oh!

Improve the stty --all output to match GNU version #9432

Are you sure you want to change the base?

Improve the stty --all output to match GNU version #9432

Uh oh!

Conversation

3v1n0 commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

ChrisDryden Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

3v1n0 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

3v1n0 Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

ChrisDryden Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

3v1n0 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

3v1n0 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

3v1n0 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 22, 2025

Uh oh!

github-actions bot commented Nov 22, 2025

Uh oh!

ChrisDryden commented Nov 24, 2025

Uh oh!

3v1n0 commented Nov 24, 2025

Uh oh!

3v1n0 commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChrisDryden commented Nov 24, 2025

Uh oh!

ChrisDryden commented Nov 24, 2025

Uh oh!

SteveLauC commented Nov 25, 2025

Uh oh!

3v1n0 commented Nov 25, 2025

Uh oh!

ChrisDryden commented Nov 25, 2025

Uh oh!

3v1n0 commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveLauC commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Improve the `stty --all` output to match GNU version #9432

Improve the `stty --all` output to match GNU version #9432

3v1n0 commented Nov 21, 2025 •

edited

Loading

ChrisDryden Nov 21, 2025 •

edited

Loading

3v1n0 commented Nov 24, 2025 •

edited

Loading

3v1n0 commented Nov 25, 2025 •

edited

Loading