Remove unsafe unwrap() calls in stdbuf error handling #9429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
- Replace get_many().unwrap() with ok_or_else() to handle missing command - Replace next().unwrap() with pattern matching for safety - Replace tempdir().unwrap() with map_err() to handle temp dir failures All stdbuf internal errors now properly exit with code 125 per GNU specification: https://www.gnu.org/s/coreutils/manual/html_node/stdbuf-invocation.html
naoNao89
force-pushed
the
fix/stdbuf-remove-unwrap
branch
from
2bd8811 to
e0c7ef7
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes three unwrap() calls that could cause panics, ensuring stdbuf properly handles errors according to GNU specification
According to GNU stdbuf documentation: