stty: Combining all open PR's to show stty GNU test passing #9427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm seeing |
|
GNU testsuite comparison: |
Contributor
Author
|
Those two commits should cover the two tests: |
|
GNU testsuite comparison: |
Contributor
Author
|
This last commit should cover the use case for the bad-speed test, would add an additional 5 passing GNU tests if this we can get a version of this into the code-base 🎉 |
|
GNU testsuite comparison: |
This was referenced Nov 22, 2025
3v1n0
reviewed
Nov 24, 2025
|
|
||
| /// GNU uses an unsigned 32-bit integer for row/col sizes, but then wraps around 16 bits | ||
| /// this function returns Some(n), where n is a u16 row/col size, or None if the string arg cannot be parsed as a u32 | ||
| fn parse_rows_cols(arg: &str) -> Option<u16> { |
There was a problem hiding this comment.
Isn't this parse logic for most integer input that is supported?
GNU does it at least for line too and for any other control char.
In general the parser seems to be worth being moved to an utility module that is share through the other tools given that in GNU the same logic (e.g. xnumtoumax) is at least used by:
nprocfoldfmtheadlscksumsplitstty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR to showcase all of the open stty PR's to show that when combined that the STTY tests are able to run on the Github action runners and that two of the GNU stty tests now pass.