Enhance mode parsing to support comma-separated mode strings in install command #9298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e` function. Add tests for comma-separated mode handling in file and directory creation.
sylvestre
reviewed
Nov 15, 2025
|
|
||
| /// Takes a user-supplied string and tries to parse to u16 mode bitmask. | ||
| /// Supports comma-separated mode strings like "ug+rwX,o+rX" (same as chmod). | ||
| pub fn parse(mode_string: &str, considering_dir: bool, umask: u32) -> Result<u32, String> { |
Contributor
There was a problem hiding this comment.
maybe write a unit test for this function :)
…g numeric, symbolic, and mixed modes, as well as handling of invalid inputs and umask considerations.
Contributor
Author
|
is this error relevant to my changes? |
Contributor
No space left on device? |
CodSpeed Performance ReportMerging #9298 will improve performances by 8.57%Comparing Summary
Benchmarks breakdown
Footnotes
|
|
GNU testsuite comparison: |
Contributor
|
thanks! It seems that mknod, mkfifo, and mkdir also supports this. I am not sure we support that if you want to have a look :) |
Contributor
Author
|
Sure |
hubot
pushed a commit
to coreutils/coreutils
that referenced
this pull request
Nov 18, 2025
Identified here: <uutils/coreutils#9298> * tests/install/basic-1.sh: Add the check.
naoNao89
pushed a commit
to naoNao89/coreutils
that referenced
this pull request
Nov 24, 2025
…ll command (uutils#9298) * Enhance mode parsing to support comma-separated mode strings in `parse` function. Add tests for comma-separated mode handling in file and directory creation. * Add comprehensive tests for mode parsing in `parse` function, covering numeric, symbolic, and mixed modes, as well as handling of invalid inputs and umask considerations. --------- Co-authored-by: Sylvestre Ledru <[email protected]>
romanstingler
pushed a commit
to romanstingler/coreutils
that referenced
this pull request
Dec 14, 2025
…ll command (uutils#9298) * Enhance mode parsing to support comma-separated mode strings in `parse` function. Add tests for comma-separated mode handling in file and directory creation. * Add comprehensive tests for mode parsing in `parse` function, covering numeric, symbolic, and mixed modes, as well as handling of invalid inputs and umask considerations. --------- Co-authored-by: Sylvestre Ledru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9250