Skip to content

sort: make compression program failures non-fatal, warn and fallback to plain files #9266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 1 commit into from
Nov 16, 2025
Merged

sort: make compression program failures non-fatal, warn and fallback to plain files #9266

cakebaker merged 1 commit into from
Nov 16, 2025

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Nov 13, 2025

Should fix tests/sort/sort-compress.sh

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9266 will degrade performances by 4.43%

Comparing sylvestre:sort-compress (09e1aa1) with main (a792ef5)

Summary

⚡ 2 improvements
❌ 1 regression
✅ 120 untouched
⏩ 5 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ sort_ascii_c_locale 21.5 ms 22.5 ms -4.43%
⚡ sort_reverse_mixed 39.1 ms 38.1 ms +2.53%
⚡ sort_unique_mixed 39.4 ms 38.6 ms +2.01%

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/sort/sort-compress is no longer failing!

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/time-style is no longer failing!
Congrats! The gnu test tests/sort/sort-compress is no longer failing!

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-compress is no longer failing!

cakebaker
cakebaker reviewed Nov 14, 2025
View reviewed changes
tests/by-util/test_sort.rs
Copy link
Contributor

@cakebaker cakebaker Nov 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code for Windows and non-Windows is identical, except of the expected error message, and so I would make only the expected error message platform-dependent. Another option would be to use the same error message on all platforms, so you don't have to care on which platform the test is run.

cakebaker
cakebaker reviewed Nov 14, 2025
View reviewed changes
tests/by-util/test_sort.rs Outdated
])
.succeeds();

// Check that it prints the error message to stderr
Copy link
Contributor

@cakebaker cakebaker Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is obvious.

Suggested change
// Check that it prints the error message to stderr

@sylvestre
sort: make compression program failures non-fatal, warn and fallback …
09e1aa1 
…to plain files

Should fix tests/sort/sort-compress.sh
@github-actions
Copy link

github-actions bot commented Nov 15, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-compress is no longer failing!

@cakebaker cakebaker merged commit a15ee09 into uutils:main Nov 16, 2025
126 of 127 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Nov 16, 2025

Congrats! The gnu test tests/sort/sort-compress is no longer failing!

Great, kudos :)

@cakebaker cakebaker mentioned this pull request Nov 16, 2025
Open
@moonfruit moonfruit mentioned this pull request Dec 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sylvestre @cakebaker