Skip to content

fix(nl): allow repeated flags to match GNU nl behavior (fixes #9132) #9140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 1 commit into from
Nov 12, 2025
Merged

fix(nl): allow repeated flags to match GNU nl behavior (fixes #9132) #9140

cakebaker merged 1 commit into from
Nov 12, 2025

Conversation

@naoNao89
Copy link
Contributor

@naoNao89 naoNao89 commented Nov 4, 2025 •
edited
Loading

Fixes #9132. uu-nl now accepts repeated flags like GNU nl. Added args_override_self(true)to all 10 value-accepting arguments.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 5, 2025
View reviewed changes
@naoNao89 naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from 5238335 to a2db784 Compare November 5, 2025 17:10
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

cakebaker
cakebaker reviewed Nov 6, 2025
View reviewed changes
@naoNao89 naoNao89 closed this by deleting the head repository Nov 6, 2025
@naoNao89 naoNao89 reopened this Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@naoNao89 naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from a2db784 to 8f1bd52 Compare November 8, 2025 21:30
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9140 will not alter performance

Comparing naoNao89:fix/nl-repeated-flags-9132 (abcfbe4) with main (5318c9c)

Summary

✅ 123 untouched
⏩ 5 skipped1

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Nov 8, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed Nov 10, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 10, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 10, 2025
View reviewed changes
cakebaker
cakebaker reviewed Nov 10, 2025
View reviewed changes
@naoNao89 naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from 8f1bd52 to 2d56770 Compare November 10, 2025 19:28
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed Nov 11, 2025
View reviewed changes
@naoNao89 naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from 2d56770 to a4819ba Compare November 11, 2025 12:59
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed Nov 11, 2025
View reviewed changes
@naoNao89 naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch 2 times, most recently from 1ed8792 to aff651d Compare November 11, 2025 17:47
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed Nov 12, 2025
View reviewed changes
@naoNao89 naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from aff651d to 01cfb02 Compare November 12, 2025 12:40
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

cakebaker
cakebaker reviewed Nov 12, 2025
View reviewed changes
@naoNao89
fix(nl): allow repeated flags to match GNU behavior
abcfbe4 
• Enable args_override_self(true) for repeated flags
• Remove unnecessary ArgAction::Append calls
• Fix tests to verify last value wins, not just succeeds
• Update test output validation for repeated flags

Fixes uutils#9132
@naoNao89 naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from 01cfb02 to abcfbe4 Compare November 12, 2025 14:06
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit d432131 into uutils:main Nov 12, 2025
126 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Nov 12, 2025

Thanks :)

@naoNao89 naoNao89 deleted the fix/nl-repeated-flags-9132 branch November 12, 2025 17:06
@moonfruit moonfruit mentioned this pull request Dec 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: uu-nl rejects repeated -b* flags that GNU nl accepts

2 participants

@naoNao89 @cakebaker