Skip to content

Add comprehensive readonly file regression tests for cp #9045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 3 commits into from
Dec 10, 2025
Merged

Add comprehensive readonly file regression tests for cp #9045

cakebaker merged 3 commits into from
Dec 10, 2025

Conversation

@naoNao89
Copy link
Contributor

@naoNao89 naoNao89 commented Oct 27, 2025

Fixes issue #5349

The tests ensure the readonly file behavior from PR #5261 cannot regress in future development.

@sylvestre
Copy link
Contributor

sylvestre commented Oct 27, 2025

please remove the trivial comments :)

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@naoNao89 naoNao89 force-pushed the add-cp-readonly-regression-tests branch from 78e2aa7 to b8d7d4a Compare October 27, 2025 10:13
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9045 will not alter performance

Comparing naoNao89:add-cp-readonly-regression-tests (271621e) with main (1ffad82)

Summary

✅ 127 untouched
⏩ 6 skipped1

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Oct 28, 2025
View reviewed changes
@naoNao89 naoNao89 force-pushed the add-cp-readonly-regression-tests branch 4 times, most recently from 5fddc7f to a1fb012 Compare October 28, 2025 10:45
@naoNao89 naoNao89 marked this pull request as draft October 28, 2025 11:00
@github-actions
Copy link

github-actions bot commented Oct 28, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@naoNao89 naoNao89 force-pushed the add-cp-readonly-regression-tests branch 2 times, most recently from 9a80703 to 112f646 Compare October 28, 2025 11:22
@naoNao89 naoNao89 marked this pull request as ready for review October 28, 2025 11:38
@github-actions
Copy link

github-actions bot commented Oct 28, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@naoNao89 naoNao89 closed this by deleting the head repository Nov 6, 2025
@naoNao89 naoNao89 reopened this Nov 7, 2025
@naoNao89 @cakebaker
feat: add comprehensive readonly file regression tests for cp
b7f4515 
- Add 10 new test functions covering readonly destination behavior
- Tests cover basic readonly copying, flag combinations, and edge cases
- Include macOS-specific clonefile behavior tests
- Ensure readonly file protection from PR uutils#5261 cannot regress
- Tests provide evidence for closing issue uutils#5349
@naoNao89 @cakebaker
perf: optimize readonly regression tests with batched I/O operations
408dcdd 
- Reduce file I/O overhead by batching file operations
- Consolidate setup operations to minimize system calls
- Improve test execution time from 0.44s to 0.27s (38% improvement)
- Maintain comprehensive test coverage for readonly file behavior
@naoNao89 @cakebaker
fix: remove duplicate tests and trivial comments per PR feedback
271621e 
- Remove test_cp_readonly_dest_regression (duplicate of test_cp_dest_no_permissions)
- Remove test_cp_readonly_dest_with_force (duplicate of test_cp_arg_force)
- Remove test_cp_readonly_dest_with_remove_destination (duplicate of test_cp_arg_remove_destination)
- Remove test_cp_macos_clonefile_readonly (duplicate of test_cp_existing_target)
- Remove test_cp_normal_copy_still_works (duplicate of test_cp_existing_target)
- Remove trivial performance comments from readonly tests
- Keep existing proven tests per maintainer preferences
- Keep unique readonly tests that provide additional coverage
@cakebaker cakebaker force-pushed the add-cp-readonly-regression-tests branch from 112f646 to 271621e Compare December 10, 2025 08:33
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 415d01c into uutils:main Dec 10, 2025
127 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Dec 10, 2025

Thanks!

@naoNao89 naoNao89 deleted the add-cp-readonly-regression-tests branch December 10, 2025 17:19
naoNao89 added a commit to naoNao89/coreutils that referenced this pull request Dec 14, 2025
@naoNao89
cp: add readonly file regression tests (uutils#9045)
1479259 
* feat: add comprehensive readonly file regression tests for cp

- Add 10 new test functions covering readonly destination behavior
- Tests cover basic readonly copying, flag combinations, and edge cases
- Include macOS-specific clonefile behavior tests
- Ensure readonly file protection from PR uutils#5261 cannot regress
- Tests provide evidence for closing issue uutils#5349

* perf: optimize readonly regression tests with batched I/O operations

- Reduce file I/O overhead by batching file operations
- Consolidate setup operations to minimize system calls
- Improve test execution time from 0.44s to 0.27s (38% improvement)
- Maintain comprehensive test coverage for readonly file behavior

* fix: remove duplicate tests and trivial comments per PR feedback

- Remove test_cp_readonly_dest_regression (duplicate of test_cp_dest_no_permissions)
- Remove test_cp_readonly_dest_with_force (duplicate of test_cp_arg_force)
- Remove test_cp_readonly_dest_with_remove_destination (duplicate of test_cp_arg_remove_destination)
- Remove test_cp_macos_clonefile_readonly (duplicate of test_cp_existing_target)
- Remove test_cp_normal_copy_still_works (duplicate of test_cp_existing_target)
- Remove trivial performance comments from readonly tests
- Keep existing proven tests per maintainer preferences
- Keep unique readonly tests that provide additional coverage
romanstingler pushed a commit to romanstingler/coreutils that referenced this pull request Dec 14, 2025
@naoNao89 @romanstingler
cp: add readonly file regression tests (uutils#9045)
a65c6f8 
* feat: add comprehensive readonly file regression tests for cp

- Add 10 new test functions covering readonly destination behavior
- Tests cover basic readonly copying, flag combinations, and edge cases
- Include macOS-specific clonefile behavior tests
- Ensure readonly file protection from PR uutils#5261 cannot regress
- Tests provide evidence for closing issue uutils#5349

* perf: optimize readonly regression tests with batched I/O operations

- Reduce file I/O overhead by batching file operations
- Consolidate setup operations to minimize system calls
- Improve test execution time from 0.44s to 0.27s (38% improvement)
- Maintain comprehensive test coverage for readonly file behavior

* fix: remove duplicate tests and trivial comments per PR feedback

- Remove test_cp_readonly_dest_regression (duplicate of test_cp_dest_no_permissions)
- Remove test_cp_readonly_dest_with_force (duplicate of test_cp_arg_force)
- Remove test_cp_readonly_dest_with_remove_destination (duplicate of test_cp_arg_remove_destination)
- Remove test_cp_macos_clonefile_readonly (duplicate of test_cp_existing_target)
- Remove test_cp_normal_copy_still_works (duplicate of test_cp_existing_target)
- Remove trivial performance comments from readonly tests
- Keep existing proven tests per maintainer preferences
- Keep unique readonly tests that provide additional coverage
@moonfruit moonfruit mentioned this pull request Dec 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@naoNao89 @sylvestre @cakebaker