Clippy fix #8991
Merged
Clippy fix #8991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yes we can vave Box::new but then we have to clone the chunk..
sylvestre
reviewed
Oct 24, 2025
src/uu/tail/src/chunks.rs
Outdated
| /// let mut chunks = BytesChunkBuffer::new(num_print); | ||
| /// chunks.fill(&mut reader).unwrap(); | ||
| /// ``` | ||
| #[allow(clippy::replace_box)] |
Contributor
|
@devnexen we use a MSRV of |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
asder8215
pushed a commit
to asder8215/coreutils
that referenced
this pull request
Oct 24, 2025
* uu: addressing clippy warning, find_kp_breakpoints modernize while loop. * however here clippy advice do not seem a gain. yes we can vave Box::new but then we have to clone the chunk.. * feedback, remove also too recent clippy annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.