Skip to content

Conversation

@cakebaker
Copy link
Contributor

This PR handles the scenario in which --files0-from=- is specified and - is piped in. It should make the test du/files0-from.pl pass again.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker marked this pull request as draft October 23, 2025 14:49
@cakebaker
Copy link
Contributor Author

cakebaker commented Oct 23, 2025

Hm, for some reason the GNU test still fails, also locally :|

@cakebaker cakebaker force-pushed the du_files0_from_stdin branch from 334d33c to 4f0acb7 Compare October 24, 2025 14:31
@cakebaker
Copy link
Contributor Author

Ok, I think I figured out the issue: one of our string replacements in build-gnu.sh became outdated and worked only partially.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/du/files0-from is no longer failing!

@cakebaker cakebaker marked this pull request as ready for review October 24, 2025 14:56
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/du/files0-from is no longer failing!

@sylvestre sylvestre merged commit 5b261bc into uutils:main Dec 5, 2025
130 checks passed
@cakebaker cakebaker deleted the du_files0_from_stdin branch December 6, 2025 06:03
mattsu2020 pushed a commit to mattsu2020/coreutils that referenced this pull request Dec 6, 2025
* du: handle --files0-from=- with piped in '-'

* build-gnu.sh: remove incorrect string replacement

in tests/du/files0-from.pl

---------

Co-authored-by: Sylvestre Ledru <[email protected]>
romanstingler pushed a commit to romanstingler/coreutils that referenced this pull request Dec 14, 2025
* du: handle --files0-from=- with piped in '-'

* build-gnu.sh: remove incorrect string replacement

in tests/du/files0-from.pl

---------

Co-authored-by: Sylvestre Ledru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants