test(nohup): improve coverage for fd replacement and error paths #8920
+165
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive tests for nohup's file descriptor replacement logic and error handling, increasing coverage of previously untested code paths. New tests cover: - Creating nohup.out in current directory - Appending to existing nohup.out - Stderr redirection to stdout - Command not found error (exit codes 126/127) - Fallback to $HOME/nohup.out when cwd is not writable (Linux/FreeBSD) - POSIXLY_CORRECT environment variable handling (Linux/FreeBSD) Tests use .terminal_simulation(true) to properly test TTY-dependent behavior. Platform-specific tests are gated behind appropriate cfg attributes. Addresses uutils#1857
naoNao89
force-pushed
the
test/nohup-coverage-1857
branch
from
96fde9e to
361b517
Compare
- Add 'nowrite' to cspell jargon dictionary - Fix clippy::uninlined_format_args warnings in test_nohup.rs - Remove nested #[test] function that caused unnameable-test-items error - Format strings now use inline variable syntax
naoNao89
force-pushed
the
test/nohup-coverage-1857
branch
from
e0ce292 to
e6892ce
Compare
|
GNU testsuite comparison: |
Contributor
|
nice!
|
naoNao89
added a commit
to naoNao89/coreutils
that referenced
this pull request
Oct 25, 2025
…ils#8920) * test(nohup): expand test coverage for fd replacement and error paths Add comprehensive tests for nohup's file descriptor replacement logic and error handling, increasing coverage of previously untested code paths. New tests cover: - Creating nohup.out in current directory - Appending to existing nohup.out - Stderr redirection to stdout - Command not found error (exit codes 126/127) - Fallback to $HOME/nohup.out when cwd is not writable (Linux/FreeBSD) - POSIXLY_CORRECT environment variable handling (Linux/FreeBSD) Tests use .terminal_simulation(true) to properly test TTY-dependent behavior. Platform-specific tests are gated behind appropriate cfg attributes. Addresses uutils#1857 * fix: CI failures for cspell and clippy in nohup tests - Add 'nowrite' to cspell jargon dictionary - Fix clippy::uninlined_format_args warnings in test_nohup.rs - Remove nested #[test] function that caused unnameable-test-items error - Format strings now use inline variable syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on issue #1857 about nohup test coverage.
What's here:
The uncovered lines:
Line 119 (and similar at L110, L124) are
dup2()syscall error paths. These only trigger if the kernel fails to duplicate file descriptors - basically unreachable without fault injection tools. I documented this in the coverage analysis.The remaining uncovered lines are defensive error handling that's realistically untestable in the current test environment. IMO they should stay as-is - better to have defensive code than risk removing safety checks.