cp: display symlink creation with --verbose #8899
Conversation
|
GNU testsuite comparison: |
|
Apologies about spamming CI. I'll get the pre-commit hook working for next time. |
|
GNU testsuite comparison: |
|
Ty for taking care of it for me, I'm quite busy lol. Would you mind squashing your last three commits into a single one, and renaming the second one with a |
Ada-Armstrong
force-pushed
the
cp_recursive_verbose_symlink
branch
from
5332c28 to
251d3fb
Compare
|
No problem. I merged all of the commits into one to reduce the commit pollution. |
|
GNU testsuite comparison: |
|
That spurious Android test failure is driving me up the walls. It's not your fault lol, it's been happening on and off recently. If it was working then, it should be working now in spite of this cursed CI check. Now that I'm complaining, how are GitHub's load-bearing CI Mac Minis so slow lol. |
src/uu/cp/src/cp.rs
Outdated
| fn print_removed_path(path: &Path) { | ||
| println!( | ||
| "{}", | ||
| translate!("cp-verbose-removed", "path" => path.quote()) | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure of the added value to wrap a single print in a function. I think you can inline it
|
GNU testsuite comparison: |
|
LGTM. If you can squash the second commit into the first, that would be great. I'd rather rebase than merge, and in order to keep master "clean", it's better to get rid of "fix commits". |
cp: display removed files with --verbose
Ada-Armstrong
force-pushed
the
cp_recursive_verbose_symlink
branch
from
39796b4 to
58e602c
Compare
|
GNU testsuite comparison: |
3 participants
Fix for #8893.
Additionally, files which are removed are displayed when
--verboseis enabled, to mimic GNUcpbehaviour.