od: add support for -S #8849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cakebaker merged 3 commits into uutils:main from sylvestre:od-n

Oct 17, 2025

Contributor

sylvestre commented Oct 8, 2025

should fix tests/od/od-N

github-actions bot commented Oct 8, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/od/od-N is no longer failing!

sylvestre marked this pull request as ready for review

October 9, 2025 05:34

cakebaker reviewed

View reviewed changes

tests/by-util/test_od.rs Outdated

Comment on lines 1007 to 1012

    
                  // Test with -S10 to filter out short strings

                  new_ucmd!()

                      .arg("-S10")

                      .pipe_in(b"\x01          \x00          \x00")

                      .succeeds()

                      .stdout_is("0000001           \n0000014           \n");

Contributor

cakebaker Oct 9, 2025

There is a disconnect between the comment and the code: there are no short strings in the piped in data that could be filtered out ;-)

cakebaker reviewed

View reviewed changes

tests/by-util/test_od.rs Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

tests/by-util/test_od.rs Show resolved Hide resolved

github-actions bot commented Oct 9, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/od/od-N is no longer failing!

cakebaker reviewed

View reviewed changes

tests/by-util/test_od.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uu/od/src/od.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uu/od/src/od.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uu/od/src/od.rs Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uu/od/src/od.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uu/od/src/od.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uu/od/src/od.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

Contributor

cakebaker left a comment

Done :)

sylvestre added 3 commits

October 16, 2025 06:13


          fix tests/od/od-N

b1afe34


          od: dedup some code

fd75c37


          od: translate some strings

c1d9fc3

sylvestre force-pushed the od-n branch from d327058 to c1d9fc3 Compare

October 16, 2025 10:14

github-actions bot commented Oct 16, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/od/od-N is no longer failing!

cakebaker merged commit 0258583 into uutils:main

122 checks passed

Contributor

cakebaker commented Oct 17, 2025

Congrats! The gnu test tests/od/od-N is no longer failing!

Great, kudos :)

BrewTestBot mentioned this pull request

uutils-coreutils 0.3.0 Homebrew/homebrew-core#251041

Merged

moonfruit mentioned this pull request

uutils-selected 0.3.0 moonfruit/homebrew-tap#345

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet