ls: Fix excessive ls -al syscalls for ACL metadata #8841

kimono-koans · 2025-10-07T20:02:49Z

Reduces syscalls by searching for the specific ACL xattr key instead of requesting a list of all keys and values.

➜  ~ strace -c ./program/coreutils/target/release/ls -al
...
% time     seconds  usecs/call     calls    errors syscall
------ ----------- ----------- --------- --------- ------------------
 20.88    0.001559          11       130           listxattr
 16.02    0.001196          35        34           getdents64
 14.43    0.001077          13        79         9 statx
 10.89    0.000813         813         1           execve
  6.47    0.000483          17        28         1 openat
  4.65    0.000347          11        31           close
  4.21    0.000314          24        13           mmap
  4.07    0.000304          23        13           read
  3.99    0.000298          11        27           fstat
  3.03    0.000226          16        14         6 readlink
  1.81    0.000135          33         4         4 connect
  1.62    0.000121          30         4           socket
  1.25    0.000093          93         1           write
  1.11    0.000083          13         6           newfstatat
  0.90    0.000067          11         6           brk
  0.64    0.000048           6         7           rt_sigaction
  0.60    0.000045           9         5           mprotect
  0.58    0.000043           8         5           lseek
  0.58    0.000043           8         5           ioctl
  0.50    0.000037          18         2           munmap
  0.46    0.000034          17         2           pread64
  0.31    0.000023           7         3           sigaltstack
  0.25    0.000019          19         1         1 access
  0.15    0.000011           5         2           getrandom
  0.13    0.000010          10         1           arch_prctl
  0.11    0.000008           8         1           sched_getaffinity
  0.11    0.000008           8         1           set_tid_address
  0.11    0.000008           8         1           set_robust_list
  0.11    0.000008           8         1           rseq
  0.07    0.000005           2         2           prlimit64
  0.00    0.000000           0         1           poll
------ ----------- ----------- --------- --------- ------------------
100.00    0.007466          17       431        21 total

➜  ~ strace -c ./program/coreutils/target/release/ls -al
...
% time     seconds  usecs/call     calls    errors syscall
------ ----------- ----------- --------- --------- ------------------
 19.08    0.000962          28        34           getdents64
 17.12    0.000863          10        79         9 statx
 16.20    0.000817         817         1           execve
  8.67    0.000437          15        28         1 openat
  6.41    0.000323          24        13           mmap
  5.28    0.000266           4        66        66 getxattr
  4.20    0.000212           7        27           fstat
  4.17    0.000210          16        13           read
  3.91    0.000197           6        31           close
  3.35    0.000169          12        14         6 readlink
  2.42    0.000122          24         5           mprotect
  1.94    0.000098          16         6           brk
  1.21    0.000061           8         7           rt_sigaction
  1.03    0.000052          10         5           ioctl
  0.87    0.000044          22         2           munmap
  0.65    0.000033          16         2           pread64
  0.46    0.000023          11         2           getrandom
  0.42    0.000021           3         6           newfstatat
  0.38    0.000019           9         2           prlimit64
  0.36    0.000018          18         1         1 access
  0.36    0.000018           6         3           sigaltstack
  0.34    0.000017          17         1           poll
  0.34    0.000017           3         5           lseek
  0.22    0.000011          11         1           sched_getaffinity
  0.18    0.000009           9         1           arch_prctl
  0.16    0.000008           8         1           set_tid_address
  0.16    0.000008           8         1           rseq
  0.14    0.000007           7         1           set_robust_list
  0.00    0.000000           0         1           write
  0.00    0.000000           0         4           socket
  0.00    0.000000           0         4         4 connect
------ ----------- ----------- --------- --------- ------------------
100.00    0.005042          13       367        87 total

…s/coreutils into reduce_syscalls_acls

…er file has xattrs, solution: create two fns which test for acl, and for the set_cap xattr

Store xattr calls

…s/coreutils into reduce_syscalls_acls

github-actions · 2025-11-24T22:49:41Z

GNU testsuite comparison:

Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

github-actions · 2025-11-25T02:13:53Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

github-actions · 2025-11-25T05:14:45Z

GNU testsuite comparison:

Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

github-actions · 2025-11-25T07:57:21Z

GNU testsuite comparison:

Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

.vscode/settings.json

src/uu/ls/src/colors.rs

src/uu/ls/src/ls.rs

src/uucore/src/lib/features/fsxattr.rs

tests/by-util/test_mkdir.rs

github-actions · 2025-11-25T08:37:49Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

github-actions · 2025-11-26T21:36:49Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

github-actions · 2025-11-26T22:10:57Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

github-actions · 2025-11-27T02:50:17Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

…s/coreutils into reduce_syscalls_acls

github-actions · 2025-11-27T22:18:29Z

GNU testsuite comparison:

Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

github-actions · 2025-11-28T20:45:20Z

GNU testsuite comparison:

Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

kimono-koans added 30 commits September 18, 2025 15:11

Initial commit

44efeaa

Merge branch 'uutils:main' into reduce_syscalls_acls

41fb8f9

Add default ACL

18ee2b8

Merge branch 'reduce_syscalls_acls' of https://github.com/kimono-koan…

95f5c05

…s/coreutils into reduce_syscalls_acls

Revert, do not count a default acl key as an ACL because GNU does not

80df9ee

Wrapped Result<Option<Vec<_>>> must be non-empty to indicate an ACL

6616412

Add back default ACL

d68298d

Cleanup

65f2b1f

Avoid 2nd syscall for non-directories

c5be794

Cleanup

22cf205

Fix buggy tests

9818dc0

Merge branch 'main' into reduce_syscalls_acls

cb75dac

Lazily obtain ACL, only really useful in LongFormat

ff6748e

Cleanup

59198d3

Cleanup

d80eb15

Cleanup

a97d3af

Fix broken test

d7271bf

Cleanup

c9a71e0

Cleanup

35e9ff8

Cleanup

59410bd

Fix GNU test for capabilities, fn has_acl previously tested for wheth…

5b0ede0

…er file has xattrs, solution: create two fns which test for acl, and for the set_cap xattr

Initial

f4e47ef

Merge pull request #56 from kimono-koans/store_xattrs

2b8dc11

Store xattr calls

Merge branch 'uutils:main' into reduce_syscalls_acls

d2db905

Fix spelling issue

e24f136

Cleanup

72b60f3

Merge branch 'main' into reduce_syscalls_acls

424e623

Fix lints

c479f8b

Merge branch 'reduce_syscalls_acls' of https://github.com/kimono-koan…

6c6f0e2

…s/coreutils into reduce_syscalls_acls

Fix lints

2d139bc

kimono-koans added 2 commits November 24, 2025 16:31

Merge branch 'reduce_syscalls_acls' of https://github.com/kimono-koan…

3436d92

…s/coreutils into reduce_syscalls_acls

Cleanup

1de1cb0

Fix lints

49abf54

Fix lints

2b851d7

kimono-koans added 2 commits November 25, 2025 01:41

Cleanup

a7722a3

Merge branch 'main' into reduce_syscalls_acls

f2be43f

Fix lint

6c05c35