Skip to content

Conversation

@naoNao89
Copy link
Contributor

@naoNao89 naoNao89 commented Oct 3, 2025

Use --output=size,used,avail when validating totals to avoid fragile parsing of Filesystem/Mounted on columns that may include spaces.

Benefit: makes the test robust across different mount point naming conventions and filesystem layouts.

Improve test_total robustness by using --output=size,used,avail to get
numeric-only columns, avoiding fragile whitespace parsing of Filesystem
and Mounted on columns which can contain spaces in mount point names.

This makes the test more reliable across different filesystem configurations
and mount point naming conventions.
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed Performance Report

Merging #8799 will not alter performance

Comparing naoNao89:test/df-total-whitespace-fix (d1d5e7a) with main (cea3f22)

Summary

✅ 65 untouched
⏩ 73 skipped1

Footnotes

  1. 73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cakebaker cakebaker merged commit aa40a11 into uutils:main Oct 3, 2025
96 of 97 checks passed
@cakebaker
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants