Skip to content

tests(tee): Add GNU-compat write-error and broken-pipe tests (#4627) #8797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sylvestre merged 2 commits into from
Oct 4, 2025
Merged

tests(tee): Add GNU-compat write-error and broken-pipe tests (#4627) #8797

sylvestre merged 2 commits into from
Oct 4, 2025

Conversation

@naoNao89
Copy link
Contributor

@naoNao89 naoNao89 commented Oct 3, 2025 •
edited
Loading

Part of #4627 (split from #8684 per maintainer request)

Adds tests to cover tee --output-error behavior and broken pipe robustness:

  • test_output_error_flag_without_value_defaults_warn_nopipe
  • test_output_error_presence_only_broken_pipe_unix
  • test_broken_pipe_early_termination_stdout_only
  • test_write_failure_reports_error_and_nonzero_exit

Notes:

  • Aligns with GNU tests in tests/misc/tee.sh and tests/misc/write-errors.sh
  • Guards applied for Unix-only semantics and FreeBSD exclusion to avoid CI hangs reported earlier.

Tracked at #4627

@naoNao89
tests(tee): Add GNU-compat write-error and broken-pipe tests (uutils#…
5aeb7fd 
…4627)

Add comprehensive test coverage for tee --output-error and broken pipe behavior:

- test_output_error_flag_without_value_defaults_warn_nopipe: Verify default behavior
- test_output_error_presence_only_broken_pipe_unix: Non-crash on SIGPIPE
- test_broken_pipe_early_termination_stdout_only: Early termination robustness
- test_write_failure_reports_error_and_nonzero_exit: Error reporting validation

These tests address remaining gaps from GNU test suite tests/misc/tee.sh and
tests/misc/write-errors.sh highlighted in uutils#4627. Platform-specific guards
(#[cfg(unix)], FreeBSD exclusion) ensure cross-platform compatibility.
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 3, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8797 will not alter performance

Comparing naoNao89:test/tee-write-error-broken-pipe (8b46c58) with main (1331ff1)1

Summary

✅ 75 untouched
🆕 2 new
⏩ 73 skipped2

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 nl_large_file[10] N/A 128.1 ms N/A
🆕 nl_many_lines[100000] N/A 101.6 ms N/A

Footnotes

  1. No successful run was found on main (03f160c) during the generation of this report, so 1331ff1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre merged commit f860610 into uutils:main Oct 4, 2025
97 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@naoNao89 @sylvestre