Skip to content

fix(ptx): Remove extra space before truncation marker and add a related test #8784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 3 commits into from
Oct 2, 2025
Merged

fix(ptx): Remove extra space before truncation marker and add a related test #8784

cakebaker merged 3 commits into from
Oct 2, 2025

Conversation

@Misakait
Copy link
Contributor

@Misakait Misakait commented Oct 1, 2025

Summary

This PR fixes a compatibility bug in ptx where an extra leading space was added before the truncation marker in both roff (-G) and tex formats. The output now matches GNU ptx.

Related Issue

Closes #8783

Changes Made

  • Modified the trim_idx function to correctly trim leading whitespace from the "after" context before truncation calculations.
  • Added the regression test test_truncation_no_extra_space_in_after to verify the fix and prevent future regressions.

GNU ptx (Correct Behavior)
image
uutils/ptx Before Fix
image
uutils/ptx After Fix
PixPin_2025-10-02_04-39-44

How to Test

The bug can be verified with the following test case. After this fix, the output of uutils/ptx is identical to GNU ptx.

echo "Rust is funnnnnnnnnnnnnn" | cargo run -- -G -w 30

@Misakait
fix(ptx): Remove extra space before truncation marker and a regressio…
74beb20 
…n test (`test_truncation_no_extra_space_in_after`) has been added. Close#8783
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 2, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8784 will not alter performance

Comparing Misakait:fix/ptx-truncation-space (4dc0585) with main (c883445)

Summary

✅ 65 untouched
⏩ 73 skipped1

Footnotes

  1. 73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Misakait
fix(ptx): Remove extra space before truncation marker and a regressio…
3f823f4 
…n test (`test_truncation_no_extra_space_in_after`) has been added. Close#8783
@Misakait
Merge remote-tracking branch 'origin/fix/ptx-truncation-space' into f…
4dc0585 
…ix/ptx-truncation-space
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@Misakait Misakait mentioned this pull request Oct 2, 2025
Merged
@cakebaker cakebaker merged commit 9064619 into uutils:main Oct 2, 2025
97 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Oct 2, 2025

Thanks for your PR!

@Misakait
Copy link
Contributor Author

Misakait commented Oct 2, 2025

Thanks for your PR!

You're welcome! Happy to contribute!

@Misakait Misakait deleted the fix/ptx-truncation-space branch October 3, 2025 12:09
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ptx: Extra space is added before truncation marker

2 participants

@Misakait @cakebaker