Skip to content

ls: remove unnecessary getgrgid handling for Redox OS #8779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sylvestre merged 1 commit into from
Sep 30, 2025
Merged

ls: remove unnecessary getgrgid handling for Redox OS #8779

sylvestre merged 1 commit into from
Sep 30, 2025
+1 −1

Conversation

@Connor-GH
Copy link

@Connor-GH Connor-GH commented Sep 30, 2025

Redox OS now has getgrgid as seen in https://gitlab.redox-os.org/redox-os/relibc/-/blob/master/src/header/grp/mod.rs?ref_type=0636af21a468f04971bad11eb4571bcb94fdfa81#L253, so we can remove this special handling. This allows the group name to show up on Redox OS, instead of just the group id.

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit e4835ac into uutils:main Sep 30, 2025
95 of 96 checks passed
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 30, 2025

CodSpeed Performance Report

Merging #8779 will not alter performance

Comparing Connor-GH:main (6df1f80) with main (9351b40)1

Summary

✅ 55 untouched
⏩ 73 skipped2

Footnotes

  1. No successful run was found on main (6df1f80) during the generation of this report, so 9351b40 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Connor-GH @sylvestre