ls: Lazily obtain FileType, eagerly obtain Metadata when Metadata is available #8753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 34cbcb3.
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #8753 will improve performances by 11.28%Comparing Summary
Benchmarks breakdown
Footnotes
|
kimono-koans
changed the title
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
10% improvement, bravo!
Kudos |
sylvestre
reviewed
Sep 29, 2025
| // it will avoid a call to stat() | ||
| if !self.must_dereference { | ||
| if let Some(dir_entry) = &self.de { | ||
| if let Some(dir_entry) = RefCell::take(&self.de).as_deref() { |
Contributor
There was a problem hiding this comment.
RefCell::take() permanently removes the value, no ?
(it might impact caching)
Did you consider using self.de.borrow() instead ?
sylvestre
reviewed
Sep 29, 2025
sylvestre
reviewed
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup PathData, remove requirement for mutable state.
Would fix: #8350