Skip to content

cp: fix recursive cp fails on files with trailing backslashes #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sylvestre merged 4 commits into from
Sep 28, 2025
Merged

cp: fix recursive cp fails on files with trailing backslashes #8747

sylvestre merged 4 commits into from
Sep 28, 2025

Conversation

@Anonymous-AAA
Copy link
Contributor

@Anonymous-AAA Anonymous-AAA commented Sep 26, 2025 •
edited
Loading

Fixes #8739

Windows style separator ('\') is not required to be included for path_ends_with_terminator function for unix

@github-actions
Copy link

github-actions bot commented Sep 26, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@Ecordonnier
Copy link
Contributor

Ecordonnier commented Sep 26, 2025

The correct spelling of seperator is separator

@erammos
Copy link
Contributor

erammos commented Sep 26, 2025

Should we change the test like this?

#[test]
fn test_path_ends_with_terminator() {
    #[cfg(windows)]
    assert!(path_ends_with_terminator(Path::new("C:\\some\\path\\")));
    #[cfg(not(windows))]
    assert!(path_ends_with_terminator(Path::new("/some/path/")));
}

@github-actions
Copy link

github-actions bot commented Sep 27, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 27, 2025

CodSpeed Performance Report

Merging #8747 will not alter performance

Comparing Anonymous-AAA:fix-recursive-cp-backslash (f7527fa) with main (32eef06)

Summary

✅ 93 untouched
⏩ 1 skipped1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@sylvestre sylvestre merged commit 52c71dc into uutils:main Sep 28, 2025
97 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

recursive cp fails on files with trailing backslashes

4 participants

@Anonymous-AAA @Ecordonnier @erammos @sylvestre