-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
GNUmakefile: Use any profile from make install #8730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you please add a check in the ci to make sure we don't regress in the future, thanks |
|
No idea about what should I test. Everything are installed at same place for each PROFILE... |
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #8730 will not alter performanceComparing Summary
Footnotes
|
|
something like this: |
|
Included |
|
GNU testsuite comparison: |
|
it regressed a freebsd test: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
FreeBSD test started with @Ecordonnier Is the file path hardcoded in tests? Is the any idea for it? |
Yes this path is where the file gets installed per default when running make install. |
See #8684 (comment) |
|
Thankyou for noting about #8684 (comment) . |
Yes |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
@Ecordonnier Can we force-enable |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
What do you mean? |
|
GNU testsuite comparison: |
|
4.0.0 was released before fixing this. Cannnot fetch binary from distribution's repo yet... |
|
GNU testsuite comparison: |
sorry but what does it mean ? :) |
|
Linux distribution depending on |
|
Still difficult to merge this?
|
what do you mean?
this is fine, no ? |
|
No. Because it is difficult to install smaller binary with manpages, completions, etc... manually. Please do not hardcode release profile. |
|
distro packagers can always patches the sources ;) |
|
GNU testsuite comparison: |
|
Yes. But tracing upstream's change is difficult. Please avoid hardcoding . The fact that |
|
yeah, you have been clear, don't worry! |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
Meaning of diff caused by this PR is clear now (by separating PRs). |
|
GNU testsuite comparison: |
|
Thankyou! I and Ubuntu can drop a patch now. |
GNUmakefile: Use any profile from make install
GNUmakefile: Use any profile from make install
Allow to use any profile at
makee.g.make install PROFILE=release-fast.