Skip to content

df: add tracing zero and rounding #8685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sylvestre merged 4 commits into from
Oct 16, 2025
Merged

df: add tracing zero and rounding #8685

sylvestre merged 4 commits into from
Oct 16, 2025

Conversation

@bakanovskii
Copy link
Contributor

@bakanovskii bakanovskii commented Sep 20, 2025 •
edited
Loading

Fixes: #8683
Fixes: #8690

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8685 will not alter performance

Comparing bakanovskii:df-fix-tracing-zero (146ac84) with main (5c15d79)

Summary

✅ 41 untouched
⏩ 64 skipped1

Footnotes

  1. 64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Sep 20, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

sylvestre commented Sep 24, 2025

could you please add tests? thanks

@bakanovskii
Copy link
Contributor Author

bakanovskii commented Sep 24, 2025

could you please add tests? thanks

I refactored the tests to cover both modes or should I add a separate test just for mode with tracing zeroes?

@sylvestre
Copy link
Contributor

sylvestre commented Sep 24, 2025

yeah, please add a test in tests/by-util/test_df.rs too

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

GNU testsuite comparison:

GNU test failed: tests/tail/overlay-headers. tests/tail/overlay-headers is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@bakanovskii
Copy link
Contributor Author

bakanovskii commented Sep 24, 2025

yeah, please add a test in tests/by-util/test_df.rs too

done, however there are some stdbuf error in the CI, is this ok?

@bakanovskii
df: add tracing zero for single digits
f03c452 
Signed-off-by: Alexander Bakanovskii <[email protected]>
@bakanovskii bakanovskii changed the title df: add tracing zero for single digits df: add tracing zero and rounding Sep 29, 2025
@bakanovskii
tests/df: test 3 digit rounding
146ac84 
Signed-off-by: Alexander Bakanovskii <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 29, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@bakanovskii
Copy link
Contributor Author

bakanovskii commented Oct 15, 2025

@sylvestre, hello! Can you please look again at this PR?

@sylvestre sylvestre merged commit 6e422b7 into uutils:main Oct 16, 2025
97 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2025
Merged
naoNao89 pushed a commit to naoNao89/coreutils that referenced this pull request Oct 25, 2025
@bakanovskii @naoNao89
df: add tracing zero and rounding (uutils#8685)
c2694b4
@moonfruit moonfruit mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

df: no rounding with -H flag df: no tracing zero in -h

2 participants

@bakanovskii @sylvestre